Skip to content

Comments

Removed loginOrLink for Wagmi WC#354

Merged
IAmKio merged 2 commits intostagingfrom
fix/wc_login_request
Jun 26, 2025
Merged

Removed loginOrLink for Wagmi WC#354
IAmKio merged 2 commits intostagingfrom
fix/wc_login_request

Conversation

@LeonMorrison-tech
Copy link
Collaborator

@LeonMorrison-tech LeonMorrison-tech commented Jun 25, 2025

Description

  • Removed loginOrLink
  • Fixed path for wagmi wc

How Has This Been Tested?

  • Tested on simulator
  • Tested on Desktop browser

Screenshots (if appropriate):

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-06-25.at.16.09.28.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

  • Bug Fixes
    • Improved wallet connection status handling for more accurate menu and authentication behavior.
    • Enhanced logout process to ensure wallet is properly disconnected before clearing account data.
  • Refactor
    • Streamlined authentication checks to consistently consider both traditional login and wallet connection.
    • Removed unused wallet auto-login logic from the login page for cleaner behavior.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

Walkthrough

This update refactors authentication and wallet connection logic across several components. It replaces various local wallet state checks with the useAccount hook from the wagmi library, centralizing wallet connection state management. Conditional rendering and logout flows are updated to rely on the standardized isConnected state, streamlining authentication handling throughout the application.

Changes

File(s) Change Summary
src/components/BottomMenu/index.tsx Uses useAccount from wagmi to check isConnected; updates conditional rendering to include this state.
src/components/BottomMenuModal/AccountModal.tsx Refactors logout logic to use isConnected from useAccount and safely disconnects wallet before logout.
src/containers/Main.tsx Integrates useAccount for authentication and provider logic; updates effect dependencies and auth conditions.
src/pages/Login.tsx Removes automatic wallet login/linking logic by deleting useWallets usage and related effect.
src/containers/Main.test.tsx, src/test-utils/setupJest.ts Adds isConnected to mocked useAccount hook for tests, returning fixed values for address and connection.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BottomMenu
    participant wagmi_useAccount

    User->>BottomMenu: Render
    BottomMenu->>wagmi_useAccount: Get isConnected
    alt authenticated or account or isConnected
        BottomMenu-->>User: Render Menu
    else
        BottomMenu-->>User: Render nothing
    end
Loading
sequenceDiagram
    participant User
    participant AccountModal
    participant wagmi_useAccount
    participant wagmi_disconnect

    User->>AccountModal: Click Logout
    AccountModal->>wagmi_useAccount: Check isConnected
    alt isConnected is true
        AccountModal->>wagmi_disconnect: Disconnect wallet (try/catch)
    end
    alt account exists
        AccountModal->>LocalStorage: Clear account data
        AccountModal->>AccountModal: Unset account
    else
        AccountModal->>AccountModal: Try logout (catch errors)
    end
    AccountModal->>AccountModal: Clear Dapp storage
    AccountModal->>User: Navigate away
Loading

Possibly related PRs

  • pillarwallet/x#327: The main PR and the retrieved PR both modify the usage of the useAccount hook from the wagmi library within the AccountModal.tsx component and related wallet connection logic, indicating a direct code-level relationship.
  • pillarwallet/x#243: Modifies BottomMenu and authentication logic by integrating private key login state and useAccount, directly relating to the same authentication flow and rendering conditions.

Suggested reviewers

  • RanaBug
  • IAmKio

Poem

In the warren of code, connections abound,
Wallets and logins now tightly wound.
With wagmi’s hook, we check and we see,
If a bunny is logged in, or hopping free.
Logout is safer, the flow is refined—
In this patch, all our carrots aligned! 🥕

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-25T11_07_10_315Z-debug-0.log

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 25, 2025

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: c84aac0
Status: ✅  Deploy successful!
Preview URL: https://ce098649.x-e62.pages.dev
Branch Preview URL: https://fix-wc-login-request.x-e62.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/test-utils/setupJest.ts (1)

116-116: LGTM! Mock enhancement aligns with codebase refactoring.

The addition of isConnected: false to the useAccount mock properly aligns with the expanded usage of this hook across the codebase. This ensures components that depend on wallet connection status can be tested consistently.

Consider making the mock more flexible for test scenarios that need to test the connected state:

  useAccount: jest.fn().mockReturnValue({
    address: '0x',
    isConnected: false,
  }),

You might want to consider using jest.fn() with configurable return values in specific test files when testing connected states, or creating a helper function to easily override the mock values.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 463e578 and c84aac0.

📒 Files selected for processing (2)
  • src/containers/Main.test.tsx (1 hunks)
  • src/test-utils/setupJest.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/containers/Main.test.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint
  • GitHub Check: unit-tests
  • GitHub Check: build

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IAmKio IAmKio merged commit dfdbad6 into staging Jun 26, 2025
6 checks passed
@IAmKio IAmKio deleted the fix/wc_login_request branch June 26, 2025 09:35
This was referenced Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants