Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

test: fix lighting unit test TestBatchSplitRegionByRanges and a panic issue (#1086)#1138

Closed
ti-chi-bot wants to merge 1 commit into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-1086-to-release-5.0
Closed

test: fix lighting unit test TestBatchSplitRegionByRanges and a panic issue (#1086)#1138
ti-chi-bot wants to merge 1 commit into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-1086-to-release-5.0

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #1086

What problem does this PR solve?

  • Make the function call count atomic since the BatchSplitRegions method is now called in multiple routines.
  • Do not try to flush and unsafe ingest closed engine.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot
Copy link
Copy Markdown
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lonng
Copy link
Copy Markdown
Contributor

lonng commented May 25, 2021

@glorv Please resolve the conflicts.

@glorv glorv closed this May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants