test: fix lighting unit test TestBatchSplitRegionByRanges and a panic issue#1086
Conversation
glorv
changed the title
glorv
changed the title
| if engineFile.closed.Load() { | ||
| return nil | ||
| } | ||
| engineFile.closed.Store(true) |
There was a problem hiding this comment.
| if engineFile.closed.Load() { | |
| return nil | |
| } | |
| engineFile.closed.Store(true) | |
| if engineFile.closed.Swap(true) { | |
| return nil | |
| } |
|
/run-all-tests |
|
/lgtm |
|
/run-all-tests |
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: ef38b22 |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 6131cc0 |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #1138. |
5 participants
What problem does this PR solve?
BatchSplitRegionsmethod is now called in multiple routines.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release Note