lightning: refactor the backend package (#877)#957
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
blocked by #788. |
9532588 to
77e2be7
Compare
77e2be7 to
d752e15
Compare
|
/run-all-tests |
|
/build |
2 similar comments
|
/build |
|
/build |
33b506c to
d924eb5
Compare
|
/run-all-tests |
|
/merge |
|
@glorv: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/lgtm |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 7f0a696 |
|
/run-all-tests |
4b6f47a to
915afe9
Compare
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 01f10ec |
|
/unhold |
cherry-pick #877 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/957After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Split the
pkg/lightning/backendpackage into multiple parts, intended to be the true fix for #837 survivinggo mod tidy.What is changed and how it works?
The
backendpackage itself now only contains the abstract typeBackend. The concrete stuff are now split into multiple subpackages:pkg/lightning/backend/localpkg/lightning/backend/tidbpkg/lightning/backend/importerpkg/lightning/backend/kv, intended to be merged intopkg/kvin some future PRpkg/lightning/tikvpkg/lightning/backend/importer, pkg/lightning/backend/local,pkg/lightning/tikvandpkg/version` depending on the component being checked.Reverted #838 as it is proved to be useless.
Check List
Tests
Code changes
Side effects
Related changes
Release Note