This repository was archived by the owner on Jul 24, 2024. It is now read-only.
lightning: refactor the backend package#877
Merged
Merged
Conversation
kennytm
force-pushed
the
move-backends
branch
3 times, most recently
from
6f92aad to
ca53dce
Compare
Collaborator
|
/lgtm |
Collaborator
|
/lgtm |
ti-srebot
approved these changes
Mar 17, 2021
Collaborator
Author
|
/merge |
Contributor
|
/run-all-tests |
Collaborator
Author
|
We will run cherry-pick after it is confirmed this is sufficient for the go-client. |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 19, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-5.0 in PR #902 |
ti-srebot
added a commit
that referenced
this pull request
Mar 19, 2021
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 29, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #957 |
ti-chi-bot
pushed a commit
that referenced
this pull request
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Split the
pkg/lightning/backendpackage into multiple parts, intended to be the true fix for #837 survivinggo mod tidy.What is changed and how it works?
The
backendpackage itself now only contains the abstract typeBackend. The concrete stuff are now split into multiple subpackages:pkg/lightning/backend/localpkg/lightning/backend/tidbpkg/lightning/backend/importerpkg/lightning/backend/kv, intended to be merged intopkg/kvin some future PRpkg/lightning/tikvpkg/lightning/backend/importer, pkg/lightning/backend/local,pkg/lightning/tikvandpkg/version` depending on the component being checked.Reverted #838 as it is proved to be useless.
Check List
Tests
Code changes
Side effects
Related changes
Release Note