This repository was archived by the owner on Jul 24, 2024. It is now read-only.
pkg/lightning:move mock file for lightning into lightning package#837
Closed
AndreMouche wants to merge 1 commit into
Closed
pkg/lightning:move mock file for lightning into lightning package#837AndreMouche wants to merge 1 commit into
AndreMouche wants to merge 1 commit into
Conversation
Signed-off-by: shirly <AndreMouche@126.com>
disksing
approved these changes
Mar 10, 2021
Contributor
overvenus
suggested changes
Mar 10, 2021
Member
overvenus
left a comment
There was a problem hiding this comment.
Please do not split mock package.
Contributor
Author
|
why? I think it is only used for lighting, so we could and should split it. If we should merge them together, so why we need to have an independent package for lighting?
why? I think it is only used for lighting, so we could and should split it. If we should merge them together, so why we need to have an independent package for lighting? |
Collaborator
|
This PR is caused by pingcap/tidb#23183. The issue is like this:
Current solution in 23183 is to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shirly AndreMouche@126.com
What problem does this PR solve?
move the mock files for lightning into the lightning package, since these files are only used in tests for lightning.
Meanwhile after this PR merged, tidb needn't import github.com/cockroachdb/pebble indirectly.
related PR:#786
Check List
Tests
Release Note