Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

pkg/mock, pkg/lightning: unify mock files#786

Merged
ti-srebot merged 3 commits into
pingcap:masterfrom
overvenus:unify-mock
Mar 3, 2021
Merged

pkg/mock, pkg/lightning: unify mock files#786
ti-srebot merged 3 commits into
pingcap:masterfrom
overvenus:unify-mock

Conversation

@overvenus
Copy link
Copy Markdown
Member

What problem does this PR solve?

Unify mock files of BR and Lightning.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note.

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus requested review from kennytm and lance6716 March 3, 2021 07:50
@lance6716
Copy link
Copy Markdown
Contributor

/lgtm

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Mar 3, 2021
@overvenus
Copy link
Copy Markdown
Member Author

/run-all-tests

2 similar comments
@overvenus
Copy link
Copy Markdown
Member Author

/run-all-tests

@overvenus
Copy link
Copy Markdown
Member Author

/run-all-tests

@kennytm
Copy link
Copy Markdown
Collaborator

kennytm commented Mar 3, 2021

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Mar 3, 2021
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Mar 3, 2021
@glorv
Copy link
Copy Markdown
Collaborator

glorv commented Mar 3, 2021

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit f1daf8a into pingcap:master Mar 3, 2021
ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Mar 3, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #788

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants