Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

test: fix unstable CI caused by concurrent unit test#1541

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
lance6716:fix-concurrent-suite
Mar 29, 2021
Merged

test: fix unstable CI caused by concurrent unit test#1541
ti-chi-bot merged 3 commits into
pingcap:masterfrom
lance6716:fix-concurrent-suite

Conversation

@lance6716
Copy link
Copy Markdown
Collaborator

@lance6716 lance6716 commented Mar 29, 2021

What problem does this PR solve?

in #1539 https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/dm_ghpr_test/detail/dm_ghpr_test/8606/pipeline , one unit test is disturbed by other

[2021-03-29T03:59:27.882Z] FAIL: optimist_test.go:148: testOptimist.TestOptimist
[2021-03-29T03:59:27.882Z] 
[2021-03-29T03:59:27.882Z] optimist_test.go:149:
[2021-03-29T03:59:27.882Z]     t.testOptimist(c, noRestart)
[2021-03-29T03:59:27.882Z] optimist_test.go:351:
[2021-03-29T03:59:27.882Z]     c.Assert(opm, HasLen, 0)
[2021-03-29T03:59:27.882Z] ... obtained map[string]map[string]map[string]map[string]optimism.Operation = map[string]map[string]map[string]map[string]optimism.Operation{"task":map[string]map[string]map[string]optimism.Operation{"mysql-replica-1":map[string]map[string]optimism.Operation{"foo":map[string]optimism.Operation{"bar-1":optimism.Operation{ID:"task-`db`.`tbl`", Task:"task", Source:"mysql-replica-1", UpSchema:"foo", UpTable:"bar-1", DDLs:[]string{"ALTER TABLE bar ADD COLUMN c1 INT"}, ConflictStage:"none", Done:false}}}}}
[2021-03-29T03:59:27.882Z] ... n int = 0

What is changed and how it works?

seems we should use SerialSuites

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-chi-bot ti-chi-bot requested a review from lichunzhu March 29, 2021 08:27
@lance6716 lance6716 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Mar 29, 2021
@lichunzhu
Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Mar 29, 2021
@zier-one
Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Mar 29, 2021
@lance6716
Copy link
Copy Markdown
Collaborator Author

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 49ff0b3

@ti-chi-bot ti-chi-bot merged commit 7c7f660 into pingcap:master Mar 29, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Mar 29, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown

cherry pick to release-2.0 in PR #1545

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked size/XS status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants