Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

test: align with TiDB clustered index behaviour (#1538)#1539

Merged
ti-chi-bot merged 1 commit into
pingcap:release-2.0from
ti-srebot:release-2.0-415e713db316
Mar 29, 2021
Merged

test: align with TiDB clustered index behaviour (#1538)#1539
ti-chi-bot merged 1 commit into
pingcap:release-2.0from
ti-srebot:release-2.0-415e713db316

Conversation

@ti-srebot
Copy link
Copy Markdown

@ti-srebot ti-srebot commented Mar 29, 2021

cherry-pick #1538 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1539

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1539:release-2.0-415e713db316

What problem does this PR solve?

revert some of #1522

What is changed and how it works?

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added size/S status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 29, 2021
@ti-srebot ti-srebot requested review from GMHDBJD and lichunzhu March 29, 2021 03:51
@ti-chi-bot ti-chi-bot requested a review from lance6716 March 29, 2021 03:51
@lance6716
Copy link
Copy Markdown
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Mar 29, 2021
@lance6716
Copy link
Copy Markdown
Collaborator

/run-all-tests

Copy link
Copy Markdown
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Mar 29, 2021
@lance6716
Copy link
Copy Markdown
Collaborator

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 83e52dd

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

first-time-contributor size/S status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants