Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

dependency: remove alter-primary config#1522

Merged
GMHDBJD merged 2 commits into
pingcap:masterfrom
GMHDBJD:fixAlterPrimary
Mar 19, 2021
Merged

dependency: remove alter-primary config#1522
GMHDBJD merged 2 commits into
pingcap:masterfrom
GMHDBJD:fixAlterPrimary

Conversation

@GMHDBJD
Copy link
Copy Markdown
Collaborator

@GMHDBJD GMHDBJD commented Mar 19, 2021

What problem does this PR solve?

close #1520

  • TiDB nightly use non clustered index default (Even int primary key)
    • now MySQL clustered int primary key will be sync as non clustered in DM ( hope TiDB may change it but not DM🤣
  • drop primary key only works for non clustered index

so now drop primary key will not cause an error unless the user creates clustered index manually.

What is changed and how it works?

  • fix test
  • update dependency
  • remove alter-primary config in schemaTracker

Check List

Tests

  • Integration test

@GMHDBJD GMHDBJD added status/WIP This PR is still work in progress dependencies Pull requests that update a dependency file labels Mar 19, 2021
@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 and removed status/WIP This PR is still work in progress labels Mar 19, 2021
@GMHDBJD
Copy link
Copy Markdown
Collaborator Author

GMHDBJD commented Mar 19, 2021

/run-all-tests

@GMHDBJD GMHDBJD merged commit a88019c into pingcap:master Mar 19, 2021
@GMHDBJD GMHDBJD deleted the fixAlterPrimary branch March 19, 2021 09:15
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Mar 19, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown

cherry pick to release-2.0 in PR #1523

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Mar 19, 2021
lichunzhu pushed a commit that referenced this pull request Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked dependencies Pull requests that update a dependency file status/PTAL This PR is ready for review. Add this label back after committing new changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TiDB deprecate alter-primary-key config

3 participants