Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

dependency: remove alter-primary config (#1522)#1523

Merged
lichunzhu merged 1 commit into
pingcap:release-2.0from
ti-srebot:release-2.0-a88019c97769
Mar 19, 2021
Merged

dependency: remove alter-primary config (#1522)#1523
lichunzhu merged 1 commit into
pingcap:release-2.0from
ti-srebot:release-2.0-a88019c97769

Conversation

@ti-srebot
Copy link
Copy Markdown

@ti-srebot ti-srebot commented Mar 19, 2021

cherry-pick #1522 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1523

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1523:release-2.0-a88019c97769

What problem does this PR solve?

close #1520

  • TiDB nightly use non clustered index default (Even int primary key)
    • now MySQL clustered int primary key will be sync as non clustered in DM ( hope TiDB may change it but not DM🤣
  • drop primary key only works for non clustered index

so now drop primary key will not cause an error unless the user creates clustered index manually.

What is changed and how it works?

  • fix test
  • update dependency
  • remove alter-primary config in schemaTracker

Check List

Tests

  • Integration test

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added dependencies Pull requests that update a dependency file status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 19, 2021
@ti-srebot ti-srebot requested a review from lance6716 March 19, 2021 09:15
Copy link
Copy Markdown
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu merged commit 659a125 into pingcap:release-2.0 Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants