system_var, planner: add variable for controlling the algorithm of jo… by winoros · Pull Request #11269 · pingcap/docs-cn

winoros · 2022-09-09T07:09:48Z

…in reorder

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Add the description for the variable to control the join reorder algo.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

…in reorder

ti-chi-bot · 2022-09-09T07:09:50Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

Co-authored-by: Grace Cai <qqzczy@126.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

fixdb

+1

TomShawn

LGTM

TomShawn · 2022-10-13T03:01:19Z

/merge

ti-chi-bot · 2022-10-13T03:01:21Z

@TomShawn: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2022-10-13T03:01:38Z

/remove-status LGT1
/status LGT2

TomShawn · 2022-10-13T03:01:49Z

/merge

ti-chi-bot · 2022-10-13T03:01:51Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 369cc22

ti-chi-bot · 2022-10-13T03:04:20Z

In response to a cherrypick label: new pull request created: #11599.

ti-chi-bot · 2022-10-13T03:04:59Z

In response to a cherrypick label: new pull request created: #11600.

ti-chi-bot · 2022-10-13T03:05:38Z

In response to a cherrypick label: new pull request created: #11601.

#11269) (#11601)

#11269) (#11599)

#11269) (#11600)

system_var, planner: add variable for controlling the algorithm of jo…

47c570b

…in reorder

ti-chi-bot requested a review from TomShawn September 9, 2022 07:09

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2022

qiancai added v6.3 This PR/issue applies to TiDB v6.3. translation/doing This PR’s assignee is translating this PR. labels Sep 9, 2022

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Sep 9, 2022

qiancai added the area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. label Sep 9, 2022

qiancai requested review from qiancai and removed request for TomShawn September 9, 2022 07:55

qiancai self-assigned this Sep 9, 2022

shichun-0415 added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Sep 13, 2022

shichun-0415 reviewed Sep 13, 2022

View reviewed changes

Comment thread system-variables.md

qiancai reviewed Sep 13, 2022

View reviewed changes

Comment thread system-variables.md Outdated

qiancai reviewed Sep 13, 2022

View reviewed changes

Comment thread system-variables.md Outdated

winoros and others added 2 commits September 16, 2022 13:35

Update system-variables.md

bf564bb

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

Update system-variables.md

56ec47d

Co-authored-by: Grace Cai <qqzczy@126.com>

qiancai reviewed Sep 16, 2022

View reviewed changes

Comment thread system-variables.md Outdated

TomShawn assigned TomShawn and unassigned qiancai Sep 16, 2022

TomShawn added the needs-cherry-pick-release-6.3 label Sep 29, 2022

Update system-variables.md

9e3e18d

Co-authored-by: Grace Cai <qqzczy@126.com>

TomShawn reviewed Sep 29, 2022

View reviewed changes

Comment thread system-variables.md Outdated

Apply suggestions from code review

369cc22

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Oct 13, 2022

fixdb approved these changes Oct 13, 2022

View reviewed changes

TomShawn approved these changes Oct 13, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2022

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2022

TomShawn merged commit 957b64c into pingcap:master Oct 13, 2022

ti-chi-bot mentioned this pull request Oct 13, 2022

system_var, planner: add variable for controlling the algorithm of jo… (#11269) #11599

Merged

13 tasks

ti-chi-bot mentioned this pull request Oct 13, 2022

system_var, planner: add variable for controlling the algorithm of jo… (#11269) #11600

Merged

13 tasks

ti-chi-bot mentioned this pull request Oct 13, 2022

system_var, planner: add variable for controlling the algorithm of jo… (#11269) #11601

Merged

13 tasks

ti-chi-bot added a commit that referenced this pull request Oct 13, 2022

system_var, planner: add variable for controlling the algorithm of jo… (

66d04f7

#11269) (#11601)

ti-chi-bot added a commit that referenced this pull request Oct 13, 2022

system_var, planner: add variable for controlling the algorithm of jo… (

d0eac62

#11269) (#11599)

ti-chi-bot added a commit that referenced this pull request Oct 13, 2022

system_var, planner: add variable for controlling the algorithm of jo… (

75d671c

#11269) (#11600)

TomShawn mentioned this pull request Oct 13, 2022

sysvar: add 1 var pingcap/docs#10799

Merged

13 tasks

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 13, 2022

This was referenced Oct 14, 2022

sysvar: add 1 var (#10799) pingcap/docs#10851

Merged

sysvar: add 1 var (#10799) pingcap/docs#10852

Merged

sysvar: add 1 var (#10799) pingcap/docs#10853

Merged

Conversation

winoros commented Sep 9, 2022 • edited by TomShawn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fixdb left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn commented Oct 13, 2022

Uh oh!

ti-chi-bot commented Oct 13, 2022

Uh oh!

TomShawn commented Oct 13, 2022

Uh oh!

TomShawn commented Oct 13, 2022

Uh oh!

ti-chi-bot commented Oct 13, 2022

Uh oh!

ti-chi-bot commented Oct 13, 2022

Uh oh!

ti-chi-bot commented Oct 13, 2022

Uh oh!

ti-chi-bot commented Oct 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

winoros commented Sep 9, 2022 •

edited by TomShawn

Loading

ti-chi-bot commented Sep 9, 2022 •

edited

Loading