Skip to content

sysvar: add 1 var#10799

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
TomShawn:add-a-planner-sysvar
Oct 14, 2022
Merged

sysvar: add 1 var#10799
ti-chi-bot merged 2 commits into
pingcap:masterfrom
TomShawn:add-a-planner-sysvar

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Oct 13, 2022 •
edited by shichun-0415
Loading

What is changed, added or deleted? (Required)

sysvar: add 1 var
Close part of #3155

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2022
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. add-missing-docs Add missing system variables to documentation needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. translation/doing This PR's assignee is translating this PR. labels Oct 13, 2022
shichun-0415
shichun-0415 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread system-variables.md Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2022
@TomShawn @shichun-0415
Update system-variables.md
0512fc0 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 14, 2022
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Oct 14, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 14, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0512fc0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2022
@ti-chi-bot ti-chi-bot merged commit 5a7bdfb into pingcap:master Oct 14, 2022
@TomShawn TomShawn deleted the add-a-planner-sysvar branch October 14, 2022 11:10
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 14, 2022

In response to a cherrypick label: new pull request created: #10851.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 14, 2022

In response to a cherrypick label: new pull request created: #10852.

This was referenced Oct 14, 2022
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 14, 2022

In response to a cherrypick label: new pull request created: #10853.

ti-chi-bot added a commit that referenced this pull request Oct 17, 2022
@ti-chi-bot
sysvar: add 1 var (#10799) (#10853)
1d172af
ti-chi-bot added a commit that referenced this pull request Oct 17, 2022
@ti-chi-bot
sysvar: add 1 var (#10799) (#10852)
15517e6
ti-chi-bot added a commit that referenced this pull request Oct 17, 2022
@ti-chi-bot
sysvar: add 1 var (#10799) (#10851)
b6a169f
@shichun-0415 shichun-0415 mentioned this pull request Feb 2, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

add-missing-docs Add missing system variables to documentation needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomShawn @ti-chi-bot @shichun-0415