Skip to content

add 7 system variables introduced in 6.3 but have no user doc#11378

Merged
ti-chi-bot merged 14 commits into
pingcap:masterfrom
shichun-0415:missing-6.3-var-sys
Sep 28, 2022
Merged

add 7 system variables introduced in 6.3 but have no user doc#11378
ti-chi-bot merged 14 commits into
pingcap:masterfrom
shichun-0415:missing-6.3-var-sys

Conversation

@shichun-0415
Copy link
Copy Markdown
Contributor

@shichun-0415 shichun-0415 commented Sep 21, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

It is found that 7 system variables are missing in system variables. Since all system variables introduced in the product should be documented, this PR is created to document missing variables.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn September 21, 2022 12:29
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2022
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v6.3 This PR/issue applies to TiDB v6.3. and removed missing-translation-status This PR does not have translation status info. labels Sep 21, 2022
@shichun-0415 shichun-0415 self-assigned this Sep 21, 2022
@shichun-0415 shichun-0415 requested review from AilinKid, Defined2014, Yisaer, crazycs520 and gengliqi and removed request for TomShawn September 21, 2022 12:49
AilinKid
AilinKid reviewed Sep 21, 2022
View reviewed changes
Comment thread system-variables.md Outdated
AilinKid
AilinKid reviewed Sep 21, 2022
View reviewed changes
Comment thread system-variables.md Outdated
AilinKid
AilinKid reviewed Sep 21, 2022
View reviewed changes
Comment thread system-variables.md Outdated
AilinKid
AilinKid reviewed Sep 21, 2022
View reviewed changes
Comment thread system-variables.md Outdated
@shichun-0415 @AilinKid
Apply suggestions from code review
4216652 
Co-authored-by: Arenatlx <ailinsilence4@gmail.com>
Defined2014
Defined2014 reviewed Sep 21, 2022
View reviewed changes
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
shichun-0415 and others added 2 commits September 21, 2022 21:57
@shichun-0415
remove an existing variable
08fe4b2
@shichun-0415 @Defined2014
Apply suggestions from code review
37d2a73 
Co-authored-by: Hangjie Mo <mohangjie1995@gmail.com>
@shichun-0415 shichun-0415 changed the title add 8 system variables introduced in 6.3 but have no user doc add 7 system variables introduced in 6.3 but have no user doc Sep 21, 2022
@shichun-0415 shichun-0415 removed the request for review from Yisaer September 21, 2022 13:58
Defined2014
Defined2014 reviewed Sep 21, 2022
View reviewed changes
Comment thread system-variables.md
TomShawn
TomShawn reviewed Sep 22, 2022
View reviewed changes
Comment thread system-variables.md
TomShawn
TomShawn reviewed Sep 22, 2022
View reviewed changes
Comment thread system-variables.md
TomShawn
TomShawn reviewed Sep 22, 2022
View reviewed changes
Comment thread system-variables.md
@shichun-0415 @Defined2014
update tidb_ddl_flashback_concurrency
ced450b 
Co-authored-by: Hangjie Mo <mohangjie1995@gmail.com>
gengliqi
gengliqi reviewed Sep 22, 2022
View reviewed changes
Comment thread system-variables.md Outdated
@shichun-0415 @gengliqi
Apply suggestions from code review
93b5e9c 
Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
gengliqi
gengliqi reviewed Sep 22, 2022
View reviewed changes
Comment thread system-variables.md Outdated
@shichun-0415 @gengliqi
Update system-variables.md
46b52bc 
Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
crazycs520
crazycs520 reviewed Sep 22, 2022
View reviewed changes
Comment thread system-variables.md Outdated
@shichun-0415 @crazycs520
Apply suggestions from code review
aa009ed 
Co-authored-by: crazycs <crazycs520@gmail.com>
fzzf678
fzzf678 reviewed Sep 27, 2022
View reviewed changes
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md
Comment thread system-variables.md
qiancai
qiancai reviewed Sep 27, 2022
View reviewed changes
Comment thread system-variables.md Outdated
@AilinKid @qiancai
Update system-variables.md
22a9773 
Co-authored-by: Grace Cai <qqzczy@126.com>
@shichun-0415 shichun-0415 mentioned this pull request Sep 27, 2022
Merged
13 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 27, 2022
bb7133
bb7133 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qiancai
qiancai approved these changes Sep 28, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2022
@shichun-0415 shichun-0415 removed the request for review from songrijie September 28, 2022 11:24
@shichun-0415
Copy link
Copy Markdown
Contributor Author

shichun-0415 commented Sep 28, 2022

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 28, 2022
@shichun-0415
Copy link
Copy Markdown
Contributor Author

shichun-0415 commented Sep 28, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 28, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 22a9773

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 28, 2022
@ti-chi-bot ti-chi-bot merged commit 72aab61 into pingcap:master Sep 28, 2022
@shichun-0415 shichun-0415 deleted the missing-6.3-var-sys branch September 28, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AilinKid AilinKid AilinKid left review comments

@Defined2014 Defined2014 Defined2014 left review comments

@gengliqi gengliqi gengliqi left review comments

@crazycs520 crazycs520 crazycs520 left review comments

@bb7133 bb7133 bb7133 approved these changes

@qiancai qiancai qiancai approved these changes

+2 more reviewers

@TomShawn TomShawn TomShawn left review comments

@fzzf678 fzzf678 fzzf678 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@shichun-0415 shichun-0415

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.3 This PR/issue applies to TiDB v6.3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@shichun-0415 @ti-chi-bot @bb7133 @AilinKid @Defined2014 @gengliqi @crazycs520 @TomShawn @qiancai @fzzf678