Document require_primary_key system variable by joycse06 · Pull Request #9886 · pingcap/docs

joycse06 · 2022-08-09T03:42:25Z

Documenting the sysvar added in this PR

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

pingcap/tidb#36146

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-08-09T03:42:26Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

dveeden
shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

CLAassistant · 2022-08-09T03:42:29Z

All committers have signed the CLA.

ti-chi-bot · 2022-08-09T03:42:36Z

Welcome @joycse06!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/docs. 😃

joycse06 · 2022-08-09T03:43:56Z

 - Unit: Rows
 - The maximum number of rows returned by the `SELECT` statements.

+### require_primary_key <span class="version-mark">New in TBD</span>


I am not sure, at what version this will become available, it has been merged already. So I think it will be included in the next cut for next version.

But someone need to confirm it for me. 🙏

dveeden · 2022-08-11T09:10:18Z

 - Default value: `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
 - This variable controls a number of MySQL compatibility behaviors. See [SQL Mode](/sql-mode.md) for more information.

+### sql_require_primary_key <span class="version-mark">New in TBD</span>


TBD, can/should we set a version yet?

I saw with some other sysvars we included versions, I don't know how docs for different versions are rendered on the website, but I wouldn't want this sysvar doc to appear on the website for a version in which its not available. If you think that's ensured by how they are rendered, then I am happy to drop this.

The most likely scenario is the docs team will keep this PR open until the version is known. In the last few weeks prior to release they also pause the script which publishes the docs.

But I think you can state it as v6.3, since presumably this is the release to follow v6.2.

Sounds good to me. I will put in v6.3

dveeden · 2022-08-11T09:11:09Z

+
+- Scope: SESSION | GLOBAL
+- Default value: "OFF"
+- This variable, when turned "ON" will prevent table creation without primary keys in a cluster. Behaves similar to sysvar


This also prevents removal of PKs, right?

Yes, I will update the doc. 👍

…imary keys as well

morgo · 2022-08-16T14:20:54Z

 - Default value: `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
 - This variable controls a number of MySQL compatibility behaviors. See [SQL Mode](/sql-mode.md) for more information.

+### sql_require_primary_key <span class="version-mark">New in TBD</span>


The most likely scenario is the docs team will keep this PR open until the version is known. In the last few weeks prior to release they also pause the script which publishes the docs.

But I think you can state it as v6.3, since presumably this is the release to follow v6.2.

Co-authored-by: Morgan Tocker <tocker@gmail.com>

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

shichun-0415

Thanks for your efforts! LGTM

shichun-0415 · 2022-09-28T23:59:53Z

/merge

ti-chi-bot · 2022-09-28T23:59:57Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: b3a5f57

ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Aug 9, 2022

ti-chi-bot requested a review from shichun-0415 August 9, 2022 03:42

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2022

joycse06 commented Aug 9, 2022

View reviewed changes

joycse06 mentioned this pull request Aug 9, 2022

ddl: Add sql_require_primary_key sysvar pingcap/tidb#36146

Merged

12 tasks

joycse06 force-pushed the joycse06/document-sql_require_primary_key-sysvar branch from 6719b2e to cca65fd Compare August 9, 2022 03:45

Document require_primary_key system variable

6ac3583

joycse06 force-pushed the joycse06/document-sql_require_primary_key-sysvar branch from cca65fd to 6ac3583 Compare August 9, 2022 03:46

TomShawn requested review from bb7133 and dveeden August 11, 2022 07:35

TomShawn self-assigned this Aug 11, 2022

dveeden approved these changes Aug 11, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2022

PR feedback: Update doc to mention the sysvar prevents dropping of pr…

204e2d9

…imary keys as well

morgo reviewed Aug 16, 2022

View reviewed changes

joycse06 and others added 3 commits August 18, 2022 10:13

Update system-variables.md

3fae4c5

Co-authored-by: Morgan Tocker <tocker@gmail.com>

Update system-variables.md

a71d435

Co-authored-by: Morgan Tocker <tocker@gmail.com>

Update system-variables.md

5638120

Co-authored-by: Morgan Tocker <tocker@gmail.com>

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2022

Add expected version to be v6.3

26d7e4e

shichun-0415 added v6.3 This PR/issue applies to TiDB v6.3. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Sep 27, 2022

shichun-0415 reviewed Sep 27, 2022

View reviewed changes

Comment thread system-variables.md Outdated

Comment thread system-variables.md Outdated

shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Sep 27, 2022

shichun-0415 mentioned this pull request Sep 27, 2022

add 7 system variables introduced in 6.3 but have no user doc pingcap/docs-cn#11378

Merged

13 tasks

shichun-0415 assigned shichun-0415 and unassigned TomShawn Sep 27, 2022

shichun-0415 requested a review from qiancai September 28, 2022 02:18

shichun-0415 mentioned this pull request Sep 28, 2022

add 6 system variables introduced in 6.3 but have no user doc #10564

Merged

13 tasks

joycse06 and others added 2 commits September 29, 2022 07:20

Update system-variables.md

58abe84

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

Update system-variables.md

b3a5f57

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

shichun-0415 approved these changes Sep 28, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 28, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 28, 2022

ti-chi-bot merged commit 975d5be into pingcap:master Sep 29, 2022

Conversation

joycse06 commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ti-chi-bot commented Aug 9, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shichun-0415 left a comment

Choose a reason for hiding this comment

Uh oh!

shichun-0415 commented Sep 28, 2022

Uh oh!

ti-chi-bot commented Sep 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

joycse06 commented Aug 9, 2022 •

edited

Loading

ti-chi-bot commented Aug 9, 2022 •

edited

Loading

CLAassistant commented Aug 9, 2022 •

edited

Loading