Skip to content

sysvar: add 4 batch-dml related sysvars#11689

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
TomShawn:add-sysvar-txn
Oct 20, 2022
Merged

sysvar: add 4 batch-dml related sysvars#11689
ti-chi-bot merged 2 commits into
pingcap:masterfrom
TomShawn:add-sysvar-txn

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Oct 19, 2022

What is changed, added or deleted? (Required)

sysvar: add 4 batch-dml related sysvars

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2022
@TomShawn TomShawn requested a review from ekexium October 19, 2022 06:28
@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. add-missing-docs Add missing system variables, configuration items, and experimental features to documentation needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed missing-translation-status This PR does not have translation status info. labels Oct 19, 2022
ekexium
ekexium reviewed Oct 19, 2022
View reviewed changes
Comment thread system-variables.md Outdated
@TomShawn TomShawn requested a review from ekexium October 19, 2022 06:43
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Oct 19, 2022

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022
@Oreoxmt Oreoxmt self-requested a review October 19, 2022 11:24
Oreoxmt
Oreoxmt approved these changes Oct 20, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2022
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Oct 20, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e91aaba

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2022
@ti-chi-bot ti-chi-bot merged commit 0121f45 into pingcap:master Oct 20, 2022
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #11703.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 20, 2022
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#11689
c505641 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Oct 20, 2022
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #11704.

@TomShawn TomShawn deleted the add-sysvar-txn branch October 20, 2022 03:29
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #11705.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2022
Merged
13 tasks
ti-chi-bot added a commit that referenced this pull request Oct 20, 2022
@ti-chi-bot
sysvar: add 4 batch-dml related sysvars (#11689) (#11704)
2cf11cb
TomShawn added a commit that referenced this pull request Oct 20, 2022
@ti-chi-bot @TomShawn
sysvar: add 4 batch-dml related sysvars (#11689) (#11705)
afc9846 
* sysvar: add 4 batch-dml related sysvars

* Update system-variables.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-chi-bot added a commit that referenced this pull request Oct 20, 2022
@ti-chi-bot
sysvar: add 4 batch-dml related sysvars (#11689) (#11703)
005e29e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekexium ekexium ekexium approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

No one assigned

Labels

add-missing-docs Add missing system variables, configuration items, and experimental features to documentation needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @ti-chi-bot @ekexium @Oreoxmt