add the variables of batch-dml#10872
Merged
Merged
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
missing-translation-status
Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
batch-dml-variables
branch
from
36fb64f to
d6e9ac6
Compare
ekexium
commented
Oct 18, 2022
| - This variable is used to control whether to enable the batch insert feature, which is part of the deprecated batch-dml feature. When truned on, insert statements may be split into multiple transactions and be committed non-atomically. You must also turn on `tidb_enable_batch_dml` and set a positive `tidb_dml_batch_size` to make it work. | ||
|
|
||
| > **Warning:** | ||
| > batch-dml is deprecated because it's easy to misuse it and cause data corruption. Consider using [non-transactional DML](/non-transactional-dml.md) instead. |
Member
Author
There was a problem hiding this comment.
batch-insert cannot be replaced by non-transactional dml for now, but will be.
TomShawn
added
add-missing-docs
Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
batch-dml-variables
branch
from
29e8114 to
f548f3a
Compare
cfzjywxk
approved these changes
Oct 18, 2022
TomShawn
reviewed
Oct 19, 2022
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: ekexium <eke@fastmail.com>
TomShawn
removed
the
requires-version-specific-changes
Contributor
|
/remove-status LGT1 |
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 0d0475d |
ti-chi-bot
added
the
status/can-merge
Member
|
In response to a cherrypick label: new pull request created: #10885. |
This was referenced Oct 19, 2022
Member
|
In response to a cherrypick label: new pull request created: #10886. |
Member
|
In response to a cherrypick label: new pull request created: #10887. |
ti-chi-bot
pushed a commit
to ti-chi-bot/docs
that referenced
this pull request
Oct 19, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
14 tasks
ti-chi-bot
added a commit
that referenced
this pull request
Oct 19, 2022
ti-chi-bot
added a commit
that referenced
this pull request
Oct 19, 2022
13 tasks
TomShawn
added
translation/done
ti-chi-bot
added a commit
that referenced
this pull request
Oct 19, 2022
This was referenced Oct 20, 2022
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ekexium eke@fastmail.com
First-time contributors' checklist
What is changed, added or deleted? (Required)
close #3155
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?