Skip to content

update keywords.md#15595

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
Oreoxmt:translate/docs-15443
Dec 5, 2023
Merged

update keywords.md#15595
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
Oreoxmt:translate/docs-15443

Conversation

@Oreoxmt
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt commented Dec 4, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

  1. The scripts/check-keywords.sh script didn't check they "TiDBKeyword" section of "parser.y"
  2. The entries in the docs from the "TiDBKeyword" section were labeled as reserved, while that doesn't seem to be the case.
  3. Various missing keywords.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Dec 4, 2023
@Oreoxmt Oreoxmt self-assigned this Dec 4, 2023
@ti-chi-bot ti-chi-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2023
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 4, 2023
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Dec 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-04 10:31:29.750786159 +0000 UTC m=+1437118.416012351: ☑️ agreed by qiancai.

@Oreoxmt Oreoxmt added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. lgtm labels Dec 4, 2023
@Oreoxmt
Copy link
Copy Markdown
Collaborator Author

Oreoxmt commented Dec 5, 2023

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Dec 5, 2023
@ti-chi-bot ti-chi-bot Bot merged commit 51c09de into pingcap:master Dec 5, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15597.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15598.

ti-chi-bot Bot pushed a commit that referenced this pull request Dec 5, 2023
ti-chi-bot Bot pushed a commit that referenced this pull request Dec 5, 2023
@Oreoxmt Oreoxmt deleted the translate/docs-15443 branch February 5, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants