Update keywords#15443
Conversation
|
@dveeden Could you help confirm if this PR also apply to release-7.5? |
Yes it does. And also release-7.1. However that needs a careful merge as the |
|
@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
scripts/check-keywords.shscript didn't check they "TiDBKeyword" section of "parser.y"This shows the behavior for
TIDBandDESCwhich are both listed as reserved keyword in the docs:I would expect both to fail, but it looks like
TIDB(from the "TiDBKeyword" list) isn't actually reserved.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
This PR is translated from:
Other reference link(s):
parser, infoschema, executor: Add information_schema.keywords tidb#48807
parser: Sort keywords tidb#48851
Do your changes match any of the following descriptions?