parser: Sort keywords

[dveeden]

What problem does this PR solve?

Issue Number: close #48850

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #48851 (8d197f5) into master (f39e9bf) will increase coverage by 1.5516%.
Report is 30 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #48851        +/-   ##
================================================
+ Coverage   70.9922%   72.5439%   +1.5516%     
================================================
  Files          1368       1391        +23     
  Lines        403975     416545     +12570     
================================================
+ Hits         286791     302178     +15387     
+ Misses        97214      95378      -1836     
+ Partials      19970      18989       -981     

Flag	Coverage Δ
integration	43.7022% <ø> (?)
unit	71.0054% <ø> (+0.0131%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9663% <ø> (ø)
parser	∅ <ø> (∅)
br	48.2364% <ø> (-4.7358%)	⬇️

[dveeden]

Tested withTestKeywordsSorting in #48801

func TestKeywordsSorting(t *testing.T) {
	for i, kw := range parser.Keywords {
		if i > 1 && parser.Keywords[i-1].Word > kw.Word && parser.Keywords[i-1].Reserved == kw.Reserved {
			t.Errorf("%s should come after %s, please update parser.y and re-generate keywords.go\n",
				parser.Keywords[i-1].Word, kw.Word)
		}
	}
}

[dveeden]

/retest

[tiprow]

@dveeden: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dveeden]

/ok-to-test

[mjonss]

LGTM, just one question about consistency with all upper case keywords.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-11-23 17:01:13.427007266 +0000 UTC m=+510102.092233464: ☑️ agreed by tangenta.
• 2023-11-27 14:25:17.970682581 +0000 UTC m=+846346.635908777: ☑️ agreed by mjonss.

[hawkingrei]

@dveeden It needs @eason or @yudongusa‘s approve

[bb7133]

LGTM

[easonn7]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, easonn7, mjonss, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/parser/OWNERS [bb7133,easonn7,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #54220.