dev, v2.1, v3.0/reference: change the description of SQL_MODE by wshwsh12 · Pull Request #1776 · pingcap/docs-cn

wshwsh12 · 2019-08-19T11:37:30Z

What is changed, added or deleted?

Fix the description of SQL_MODE.
Now TiDB default SQL mode is same with MySQL 5.7
And TiDB does currently enable the ONLY_FULL_GROUP_BY mode by default.

Which version does your change affect?

dev, v3.0, v2.1

Closed the issue: #1742

CLAassistant · 2019-08-19T11:37:35Z

All committers have signed the CLA.

TomShawn · 2019-08-21T02:55:50Z

-+ 默认 SQL mode 不同：
-    + TiDB 中为 `STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION`
-    + MySQL 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ 默认 SQL mode **已相同**


Suggested change

+ 默认 SQL mode **已相同**

+ 默认 SQL mode 与 MySQL **已相同**

TomShawn · 2019-08-21T02:56:49Z

-+ 默认 SQL mode 不同：
-    + TiDB 中为 `STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION`
-    + MySQL 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ 默认 SQL mode **已相同**


Suggested change

+ 默认 SQL mode **已相同**

+ 默认 SQL mode 与 MySQL **已相同**

TomShawn · 2019-08-21T02:57:25Z

-+ 默认 SQL mode 不同：
-    + TiDB 中为 `STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION`
-    + MySQL 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ 默认 SQL mode **已相同**


Suggested change

+ 默认 SQL mode **已相同**

+ 默认 SQL mode 与 MySQL **已相同**

TomShawn · 2019-08-21T03:00:44Z

-    + TiDB 中为 `STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION`
-    + MySQL 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ 默认 SQL mode **已相同**
+    + TiDB 和 MySQL 5.7 均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`


Suggested change

+ TiDB 和 MySQL 5.7 均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`

+ TiDB 和 MySQL 5.7 中均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`

TomShawn · 2019-08-21T03:01:10Z

-    + TiDB 中为 `STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION`
-    + MySQL 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ 默认 SQL mode **已相同**
+    + TiDB 和 MySQL 5.7 均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`


Suggested change

+ TiDB 和 MySQL 5.7 均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`

+ TiDB 和 MySQL 5.7 中均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`

TomShawn · 2019-08-21T03:01:25Z

-    + TiDB 中为 `STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION`
-    + MySQL 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ 默认 SQL mode **已相同**
+    + TiDB 和 MySQL 5.7 均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`


Suggested change

+ TiDB 和 MySQL 5.7 均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`

+ TiDB 和 MySQL 5.7 中均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`

wshwsh12 · 2019-08-21T05:14:42Z

@TomShawn PTAL again.

TomShawn

LGTM

lilin90

LGTM

XuHuaiyu

LGTM

junlan-zhang · 2019-09-29T07:39:11Z

-    + TiDB 中为 `STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION`
-    + MySQL 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ 默认 SQL mode 与 MySQL **已相同**
+    + TiDB 和 MySQL 5.7 中均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`


@wshwsh12 Should we remove it from 默认设置的区别 part because there is no difference? We can still refer to SQL模式 for the default value of SQL mode of TiDB.

This part has been updated in #2107.

wshwsh12 requested a review from lilin90 August 19, 2019 11:41

lilin90 requested a review from TomShawn August 21, 2019 02:42

lilin90 added the translation/doing This PR’s assignee is translating this PR. label Aug 21, 2019

lilin90 assigned junlan-zhang Aug 21, 2019

TomShawn reviewed Aug 21, 2019

View reviewed changes

TomShawn changed the title ~~Fix the description of SQL_MODE.~~ dev, v2.1, v3.0/referece: change the description of SQL_MODE Aug 21, 2019

TomShawn changed the title ~~dev, v2.1, v3.0/referece: change the description of SQL_MODE~~ dev, v2.1, v3.0/reference: change the description of SQL_MODE Aug 21, 2019

wshwsh12 added 2 commits August 21, 2019 13:12

fix sql_mode

b04156b

update

cb10bba

wshwsh12 force-pushed the sql_mode branch from f352c74 to cb10bba Compare August 21, 2019 05:12

wshwsh12 requested a review from TomShawn August 21, 2019 05:14

TomShawn approved these changes Aug 21, 2019

View reviewed changes

lilin90 approved these changes Aug 21, 2019

View reviewed changes

wshwsh12 requested a review from XuHuaiyu August 21, 2019 09:38

XuHuaiyu reviewed Aug 22, 2019

View reviewed changes

Merge branch 'master' into sql_mode

cd82477

lilin90 merged commit a2813c8 into pingcap:master Aug 22, 2019

junlan-zhang reviewed Sep 29, 2019

View reviewed changes

junlan-zhang mentioned this pull request Sep 29, 2019

reference: update the description of SQL_MODE and character sets pingcap/docs#1559

Merged

junlan-zhang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 29, 2019

	+ 默认 SQL mode 已相同
	+ 默认 SQL mode 与 MySQL 已相同

	+ TiDB 和 MySQL 5.7 均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
	+ TiDB 和 MySQL 5.7 中均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`

Conversation

wshwsh12 commented Aug 19, 2019 • edited by yikeke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted?

Which version does your change affect?

Uh oh!

CLAassistant commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomShawn Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

TomShawn Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

TomShawn Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

TomShawn Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

TomShawn Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

TomShawn Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

wshwsh12 commented Aug 21, 2019

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

XuHuaiyu left a comment

Choose a reason for hiding this comment

Uh oh!

junlan-zhang Sep 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

junlan-zhang Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wshwsh12 commented Aug 19, 2019 •

edited by yikeke

Loading

CLAassistant commented Aug 19, 2019 •

edited

Loading

junlan-zhang Sep 29, 2019 •

edited

Loading