Skip to content

reference: add PD scheduling best practice#1990

Merged
dcalvin merged 8 commits into
pingcap:masterfrom
dcalvin:pd-best-practice
Nov 1, 2019
Merged

reference: add PD scheduling best practice#1990
dcalvin merged 8 commits into
pingcap:masterfrom
dcalvin:pd-best-practice

Conversation

@dcalvin
Copy link
Copy Markdown

@dcalvin dcalvin commented Oct 28, 2019

What is changed, added or deleted?

This PR added the PD Scheduling Best Practices to the Best Practice series.

Which version does your change affect?

TiDB 3.0/Dev/2.1

Only added for Dev for now.

@dcalvin dcalvin added the area/best-practices Adds or updates TiDB best practices. label Oct 28, 2019
Comment thread dev/glossary.md
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Oct 31, 2019

@dcalvin Please address comments. Thanks!

address comments

Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please apply changes to v3.0 and v2.1. Thanks!

@dcalvin
Copy link
Copy Markdown
Author

dcalvin commented Nov 1, 2019

@anotherrachel FYI. You can start the translation.

Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcalvin dcalvin merged commit dd14338 into pingcap:master Nov 1, 2019
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Nov 1, 2019

@dcalvin The new file wasn't added to TOC in v3.0 & v2.1. Please add it.

@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Nov 1, 2019
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Nov 1, 2019

@anotherrachel Please combine this PR with #2003 when you align docs. Thanks!

@anotherrachel anotherrachel added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v2.1 and removed translation/doing This PR’s assignee is translating this PR. labels Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/best-practices Adds or updates TiDB best practices. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants