Skip to content

reference/best-practices: add PD scheduling best practice#1655

Merged
anotherrachel merged 8 commits into
pingcap:masterfrom
anotherrachel:pd-best-practice
Dec 9, 2019
Merged

reference/best-practices: add PD scheduling best practice#1655
anotherrachel merged 8 commits into
pingcap:masterfrom
anotherrachel:pd-best-practice

Conversation

@anotherrachel
Copy link
Copy Markdown
Contributor

@anotherrachel anotherrachel commented Nov 15, 2019

What is changed, added or deleted?

This PR

  • added the PD Scheduling Best Practices
  • added Glossaries

What is the related PR or file link(s)?

pingcap/docs-cn#1990
pingcap/docs-cn#2003

Which version does your change affect?

dev, v2.1, v3.0 and v3.1

@anotherrachel anotherrachel added DNM translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/best-practices Adds or updates TiDB best practices. labels Nov 15, 2019
@anotherrachel anotherrachel changed the title reference: add PD scheduling best practice reference/best-practices: add PD scheduling best practice Nov 15, 2019
@anotherrachel anotherrachel marked this pull request as ready for review November 15, 2019 06:47
@anotherrachel
Copy link
Copy Markdown
Contributor Author

@dcalvin @disksing PTAL, thanks~

Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Copy link
Copy Markdown

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first batch of review

Comment thread dev/glossary.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Copy link
Copy Markdown

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first batch of review

Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/glossary.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
Comment thread dev/reference/best-practices/pd-scheduling.md Outdated
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Dec 7, 2019

pingcap/docs-cn#2106 removed two extra spaces from reference/best-practices/pd-scheduling.md. PTAL and align the changes in this PR. Thx~ @anotherrachel

Copy link
Copy Markdown

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please apply to other versions.

@anotherrachel anotherrachel merged commit 3737088 into pingcap:master Dec 9, 2019
@anotherrachel anotherrachel deleted the pd-best-practice branch January 7, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/best-practices Adds or updates TiDB best practices. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants