tidb-in-kubernetes: add specific Helm version#2298
Merged
Conversation
ran-huang
added
translation/from-docs
cofyc
approved these changes
Feb 25, 2020
lilin90
reviewed
Feb 27, 2020
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Contributor
Author
|
@lilin90 PTAL~ |
lilin90
added
the
status/can-merge
Contributor
|
/run-all-tests |
1 task
Contributor
|
cherry pick to release-3.0 in PR #2330 |
1 task
Contributor
|
cherry pick to release-3.1 in PR #2331 |
lilin90
added a commit
that referenced
this pull request
Feb 28, 2020
* tidb-in-kubernetes: add specific Helm version and command * Revert "tidb-in-kubernetes: add specific Helm version and command" This reverts commit 94e34a7. * tidb-in-kubernetes: add specific Helm version * Apply suggestions from code review Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90
added a commit
that referenced
this pull request
Feb 28, 2020
* tidb-in-kubernetes: add specific Helm version and command * Revert "tidb-in-kubernetes: add specific Helm version and command" This reverts commit 94e34a7. * tidb-in-kubernetes: add specific Helm version * Apply suggestions from code review Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
Add specific Helm versions.
Update homebrew commands.
What is the related PR or file link(s)?
Important Notice:
If your changes apply to multiple TiDB documentation versions, to trigger the bot to cherry-pick this PR to other release branches, make sure you add labels such as: