Skip to content

*: add specific Helm version#1820

Merged
lilin90 merged 9 commits into
pingcap:masterfrom
oraluben:update-helm-version
Feb 21, 2020
Merged

*: add specific Helm version#1820
lilin90 merged 9 commits into
pingcap:masterfrom
oraluben:update-helm-version

Conversation

@oraluben
Copy link
Copy Markdown
Contributor

@oraluben oraluben commented Feb 20, 2020

What is changed, added or deleted?

Specific Helm version.

What is the related PR or file link(s)?

  • Reference link(s): #1818
  • This PR is to align with:
  • N/A (not applicable)

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Feb 20, 2020
@claassistantio
Copy link
Copy Markdown

claassistantio commented Feb 20, 2020

CLA assistant check
All committers have signed the CLA.

@oraluben oraluben requested a review from cofyc February 20, 2020 08:05
Copy link
Copy Markdown
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the quick fix!

cc @lilin90 for final review

Comment thread dev/how-to/get-started/deploy-tidb-from-docker-compose.md Outdated
Comment thread dev/tidb-in-kubernetes/reference/tools/in-kubernetes.md Outdated
Comment thread dev/tidb-in-kubernetes/reference/tools/in-kubernetes.md Outdated
Comment thread v2.1-legacy/op-guide/docker-compose.md Outdated
Comment thread v3.0/tidb-in-kubernetes/reference/tools/in-kubernetes.md Outdated
Comment thread v3.1/tidb-in-kubernetes/reference/tools/in-kubernetes.md Outdated
@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Feb 20, 2020
@lilin90 lilin90 changed the title reference: specific Helm version *: update specific Helm version Feb 20, 2020
@lilin90 lilin90 changed the title *: update specific Helm version *: add specific Helm version Feb 20, 2020
oraluben and others added 7 commits February 20, 2020 23:26
@lilin90 lilin90 merged commit e2bbf62 into pingcap:master Feb 21, 2020
@lilin90 lilin90 added the size/small Changes of a small size. label Feb 21, 2020

[Helm](https://helm.sh) can be used as a template rendering engine. To use Helm, you only need to download its binary file:
[Helm](https://helm.sh) can be used as a template rendering engine. Make sure your Helm version >= 2.9.0 and < 3.0.0. To use Helm, you only need to download its binary file:
To use Helm, you only need to download its binary file:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence repeats with the previous one.

@ran-huang ran-huang added aligning and removed translation/doing This PR's assignee is translating this PR. labels Feb 21, 2020
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed aligning labels Feb 25, 2020
@ran-huang ran-huang removed the contribution This PR is from a community contributor. label Feb 26, 2020
@ran-huang ran-huang added the contribution This PR is from a community contributor. label Feb 28, 2020
sticnarf pushed a commit to sticnarf/docs that referenced this pull request Mar 20, 2020
* reference: specific Helm version

* also v2.1

* Update dev/tidb-in-kubernetes/reference/tools/in-kubernetes.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update v3.0/tidb-in-kubernetes/reference/tools/in-kubernetes.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update dev/tidb-in-kubernetes/reference/tools/in-kubernetes.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update v2.1-legacy/op-guide/docker-compose.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update dev/how-to/get-started/deploy-tidb-from-docker-compose.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update v3.1/tidb-in-kubernetes/reference/tools/in-kubernetes.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants