Skip to content

reference/performance: update replica selection policy of follower read#2311

Merged
sre-bot merged 2 commits into
pingcap:masterfrom
5kbpers:follower-read
Feb 28, 2020
Merged

reference/performance: update replica selection policy of follower read#2311
sre-bot merged 2 commits into
pingcap:masterfrom
5kbpers:follower-read

Conversation

@5kbpers
Copy link
Copy Markdown
Contributor

@5kbpers 5kbpers commented Feb 26, 2020

Signed-off-by: 5kbpers tangminghua@pingcap.com

What is changed, added or deleted?

Previously we updated replica selection policy of follower read, but seems that decription is not complete 😥. Now we can ensure it's correct for the current implement.

What is the related PR or file link(s)?

  • N/A (not applicable)

Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@5kbpers 5kbpers requested a review from lysu February 26, 2020 04:12
@TomShawn TomShawn added dev translation/doing This PR’s assignee is translating this PR. v4.0 This PR/issue applies to TiDB v4.0. labels Feb 26, 2020
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 26, 2020
@5kbpers
Copy link
Copy Markdown
Contributor Author

5kbpers commented Feb 27, 2020

PTAL @lysu

ran-huang added a commit to pingcap/docs that referenced this pull request Feb 27, 2020
…ead (#1864)

* reference/performance: correct replica selection policy of follower read

* sync with docs-cn changes

pingcap/docs-cn#2311

* Update reference/performance/follower-read.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* deleted a trailing space

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Feb 27, 2020
Copy link
Copy Markdown
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

/run-all-tests

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to release-3.1 in PR #2335

lilin90 added a commit to pingcap/docs that referenced this pull request Mar 6, 2020
…ead (#1864) (#1880)

* reference/performance: correct replica selection policy of follower read

* sync with docs-cn changes

pingcap/docs-cn#2311

* Update reference/performance/follower-read.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* deleted a trailing space

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
sticnarf pushed a commit to sticnarf/docs that referenced this pull request Mar 20, 2020
…ead (pingcap#1864)

* reference/performance: correct replica selection policy of follower read

* sync with docs-cn changes

pingcap/docs-cn#2311

* Update reference/performance/follower-read.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* deleted a trailing space

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants