Skip to content

reference/performance: correct replica selection policy of follower read#1864

Merged
ran-huang merged 5 commits into
pingcap:masterfrom
ran-huang:follower-read
Feb 27, 2020
Merged

reference/performance: correct replica selection policy of follower read#1864
ran-huang merged 5 commits into
pingcap:masterfrom
ran-huang:follower-read

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

What is changed, added or deleted?

Correct the replica selection policy of follower read.

What is the related PR or file link(s)?

Important Notice:

If your changes apply to multiple TiDB documentation versions, to trigger the bot to cherry-pick this PR to other release branches, make sure you add labels such as:

  • needs-cherry-pick-3.0
  • needs-cherry-pick-3.1
  • needs-cherry-pick-2.1

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0. v3.1 labels Feb 25, 2020
@ran-huang ran-huang requested review from 5kbpers and yikeke February 25, 2020 03:06
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Feb 26, 2020

The author makes changes to this part again in pingcap/docs-cn#2311. Please align the final version in this PR, thx~ @ran-huang

@ran-huang
Copy link
Copy Markdown
Contributor Author

Already sync with the latest version. @yikeke PTAL~

Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread reference/performance/follower-read.md Outdated
@ran-huang ran-huang added the dev label Feb 26, 2020
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@5kbpers 5kbpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 27, 2020

cherry pick to release-3.1 in PR #1880

@ran-huang ran-huang deleted the follower-read branch February 28, 2020 03:48
lilin90 added a commit that referenced this pull request Mar 6, 2020
…ead (#1864) (#1880)

* reference/performance: correct replica selection policy of follower read

* sync with docs-cn changes

pingcap/docs-cn#2311

* Update reference/performance/follower-read.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* deleted a trailing space

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
sticnarf pushed a commit to sticnarf/docs that referenced this pull request Mar 20, 2020
…ead (pingcap#1864)

* reference/performance: correct replica selection policy of follower read

* sync with docs-cn changes

pingcap/docs-cn#2311

* Update reference/performance/follower-read.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* deleted a trailing space

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants