reference: add documents about Coprocessor cache by breezewish · Pull Request #2857 · pingcap/docs-cn

breezewish · 2020-04-22T07:48:03Z

Signed-off-by: Breezewish me@breeswish.org

What is changed, added or deleted? (Required)

This PR adds a document about the Coprocessor cache, as well as its configurations.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR includes a new feature proposed by tikv/rfcs#48

Signed-off-by: Breezewish <me@breeswish.org>

TomShawn · 2020-04-22T07:57:18Z

@breeswish Please involve a technical review.

innerr · 2020-04-27T07:04:52Z

+# reuses the result when corresponding data in TiKV is unchanged, on a region basis.
+enabled = true
+
+# The capacity in MB of the cache.


capacity => memory capacity?

innerr · 2020-04-27T07:06:20Z

+# The capacity in MB of the cache.
+capacity-mb = 1000.0
+
+# Only cache requests whose result set is small.


Only .. => Bigger than .... will not be cached
Is it better?

innerr · 2020-04-27T07:10:32Z

+
+  调整该值为一个更大的值可以缓存更多种类下推请求，但也将导致缓存空间更容易被占满。注意，每个下推计算结果集大小一般都会小于 Region 大小，因此将该值设置得远超过 Region 大小没有意义。
+
+- `admission-min-process-ms`: 最小缓存的下推计算结果集计算时间，单位是 ms。若下推计算的计算时间小于该参数指定的时间，则结果集不会被缓存。


需要说明这个计算时间是在 tidb 端计算的总耗时，还是 tikv cop 内的耗时吗

innerr · 2020-04-27T07:11:55Z

+
+参数说明：
+
+- `capacity-mb`: 缓存的总数据量大小，单位是 MB。当缓存空间满时，旧缓存条目将被逐出。


淘汰算法是 LRU 吧，需要说明吗

innerr · 2020-04-27T07:13:36Z

+
+   - SQL 语句包含多个变化的条件，其他部分一致，变化的条件完全匹配一个复合索引列。
+
+     该场景下部分下部分下推结算的请求会与之前出现过的一致，部分请求能利用上下推计算结果缓存。


下部分下部分 typo

innerr · 2020-04-27T07:15:31Z

+
+     该场景下部分下部分下推结算的请求会与之前出现过的一致，部分请求能利用上下推计算结果缓存。
+
+## 观察缓存命中情况


改为 缓存效果检验 会不会更好

Signed-off-by: Breezewish <me@breeswish.org>

innerr

LGTM

sre-bot · 2020-04-29T09:05:26Z

@breeswish, please update your pull request.

sre-bot · 2020-04-29T12:43:24Z

@innerr, @TomShawn, PTAL.

sre-bot · 2020-05-01T09:05:24Z

@breeswish, please update your pull request.

sre-bot · 2020-05-01T12:43:24Z

@innerr, @TomShawn, PTAL.

sre-bot · 2020-05-04T09:05:24Z

@breeswish, please update your pull request.

sre-bot · 2020-05-04T09:05:27Z

No updates for a long time, close PR.

sre-bot · 2020-05-04T12:43:24Z

@innerr, @TomShawn, PTAL.

innerr · 2020-05-06T04:03:24Z

Any addressing need to update? @breeswish

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Signed-off-by: Breezewish <me@breeswish.org>

TomShawn · 2020-05-12T09:24:51Z

+
+## 特性说明
+
+ 所有 SQL 在单个 TiDB 上的首次执行都不会被缓存。


是 TiDB 实例吗？

sre-bot · 2020-05-14T09:26:53Z

@innerr, @TomShawn, PTAL.

yikeke

fix ci

TomShawn

LGTM

* Add copr cache documents Signed-off-by: Breezewish <me@breeswish.org> * Address comments Signed-off-by: Breezewish <me@breeswish.org> * Apply suggestions from code review Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> * Address come comments Signed-off-by: Breezewish <me@breeswish.org> * refine format * Update coprocessor-cache.md * relocate the file * Apply suggestions from code review * add toc * Update coprocessor-cache.md * Update TOC.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

sre-bot · 2020-05-14T12:31:17Z

cherry pick to release-4.0 in PR #3108

* Add copr cache documents Signed-off-by: Breezewish <me@breeswish.org> * Address comments Signed-off-by: Breezewish <me@breeswish.org> * Apply suggestions from code review Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> * Address come comments Signed-off-by: Breezewish <me@breeswish.org> * refine format * Update coprocessor-cache.md * relocate the file * Apply suggestions from code review * add toc * Update coprocessor-cache.md * Update TOC.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Add copr cache documents

924e3af

Signed-off-by: Breezewish <me@breeswish.org>

breezewish added the needs-cherry-pick-4.0 label Apr 22, 2020

TomShawn added translation/doing This PR’s assignee is translating this PR. v4.0 This PR/issue applies to TiDB v4.0. size/large Changes of a large size. labels Apr 22, 2020

TomShawn self-assigned this Apr 22, 2020

TomShawn changed the title ~~Add documents about Coprocessor cache~~ reference: add documents about Coprocessor cache Apr 22, 2020

TomShawn added the status/PTAL This PR is ready for reviewing. label Apr 27, 2020

innerr reviewed Apr 27, 2020

View reviewed changes

TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Apr 27, 2020

Address comments

d8352d8

Signed-off-by: Breezewish <me@breeswish.org>

innerr approved these changes Apr 27, 2020

View reviewed changes

TomShawn suggested changes Apr 27, 2020

View reviewed changes

breezewish and others added 2 commits May 11, 2020 10:53

Apply suggestions from code review

2b4d928

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Address come comments

e7c3ea2

Signed-off-by: Breezewish <me@breeswish.org>

refine format

e9701dc

TomShawn reviewed May 12, 2020

View reviewed changes

TomShawn and others added 3 commits May 12, 2020 17:29

Update coprocessor-cache.md

8323efc

Merge branch 'master' into wenxuan/copr-cache

f817290

relocate the file

41f35cd

yikeke reviewed May 14, 2020

View reviewed changes

Comment thread coprocessor-cache.md Outdated

Comment thread tidb-configuration-file.md Outdated

yikeke and others added 5 commits May 14, 2020 18:11

Apply suggestions from code review

13bcede

add toc

7a3e62c

Merge branch 'master' into wenxuan/copr-cache

fb07a0e

Update coprocessor-cache.md

8fa496f

Update TOC.md

ab8c7f4

TomShawn approved these changes May 14, 2020

View reviewed changes

TomShawn removed the status/require-change Needs the author to address comments. label May 14, 2020

TomShawn merged commit 2e294be into master May 14, 2020

sre-bot mentioned this pull request May 14, 2020

reference: add documents about Coprocessor cache (#2857) #3108

Merged

5 tasks

breezewish deleted the wenxuan/copr-cache branch May 14, 2020 13:52

breezewish mentioned this pull request May 14, 2020

copr: Rename copr-cache config enabled to enable pingcap/tidb#17227

Merged

TomShawn mentioned this pull request May 25, 2020

add Coprocessor cache doc pingcap/docs#2616

Merged

5 tasks

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 25, 2020

sre-bot mentioned this pull request May 28, 2020

add Coprocessor cache doc (#2616) pingcap/docs#2629

Merged

5 tasks

TomShawn mentioned this pull request Jun 2, 2020

toc: add coprocessor cache to toc #3446

Merged

5 tasks

sre-bot mentioned this pull request Jun 2, 2020

toc: add coprocessor cache to toc (#3446) #3447

Merged

5 tasks


		调整该值为一个更大的值可以缓存更多种类下推请求，但也将导致缓存空间更容易被占满。注意，每个下推计算结果集大小一般都会小于 Region 大小，因此将该值设置得远超过 Region 大小没有意义。

		- `admission-min-process-ms`: 最小缓存的下推计算结果集计算时间，单位是 ms。若下推计算的计算时间小于该参数指定的时间，则结果集不会被缓存。


		参数说明：

		- `capacity-mb`: 缓存的总数据量大小，单位是 MB。当缓存空间满时，旧缓存条目将被逐出。


		- SQL 语句包含多个变化的条件，其他部分一致，变化的条件完全匹配一个复合索引列。

		该场景下部分下部分下推结算的请求会与之前出现过的一致，部分请求能利用上下推计算结果缓存。


		该场景下部分下部分下推结算的请求会与之前出现过的一致，部分请求能利用上下推计算结果缓存。

		## 观察缓存命中情况


		## 特性说明

		+ 所有 SQL 在单个 TiDB 上的首次执行都不会被缓存。

Conversation

breezewish commented Apr 22, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

TomShawn commented Apr 22, 2020

Uh oh!

innerr Apr 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

innerr Apr 27, 2020

Choose a reason for hiding this comment

Uh oh!

innerr Apr 27, 2020

Choose a reason for hiding this comment

Uh oh!

innerr Apr 27, 2020

Choose a reason for hiding this comment

Uh oh!

innerr Apr 27, 2020

Choose a reason for hiding this comment

Uh oh!

innerr Apr 27, 2020

Choose a reason for hiding this comment

Uh oh!

innerr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sre-bot commented Apr 29, 2020

Uh oh!

sre-bot commented Apr 29, 2020

Uh oh!

sre-bot commented May 1, 2020

Uh oh!

sre-bot commented May 1, 2020

Uh oh!

sre-bot commented May 4, 2020

Uh oh!

sre-bot commented May 4, 2020

Uh oh!

sre-bot commented May 4, 2020

Uh oh!

innerr commented May 6, 2020

Uh oh!

TomShawn May 12, 2020

Choose a reason for hiding this comment

Uh oh!

sre-bot commented May 14, 2020

Uh oh!

yikeke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

sre-bot commented May 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

innerr Apr 27, 2020 •

edited

Loading