Skip to content

reference/tools: add warning for deprecated loader (#2904)#3008

Merged
sre-bot merged 4 commits into
pingcap:release-3.0from
sre-bot:release-3.0-6eb66ca8e46c
May 9, 2020
Merged

reference/tools: add warning for deprecated loader (#2904)#3008
sre-bot merged 4 commits into
pingcap:release-3.0from
sre-bot:release-3.0-6eb66ca8e46c

Conversation

@sre-bot
Copy link
Copy Markdown
Contributor

@sre-bot sre-bot commented May 8, 2020

cherry-pick #2904 to release-3.0


What is changed, added or deleted? (Required)

Loader now is deprecated and not maintained anymore, so add a warning to suggest user switch to TiDB Lightning.

Note: this PR also changes the loader.md file encoding from windows format to unix format, that is the new line is changed from CRLF to LF. See here for details (https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot added the type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR. label May 8, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 9, 2020

@kennytm @WangXiangUSTC PTAL

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2020
@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented May 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 9dc84af into pingcap:release-3.0 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants