Skip to content

reference/tools: add warning for deprecated loader#2904

Merged
kennytm merged 6 commits into
pingcap:masterfrom
tennix:loader-warning
May 8, 2020
Merged

reference/tools: add warning for deprecated loader#2904
kennytm merged 6 commits into
pingcap:masterfrom
tennix:loader-warning

Conversation

@tennix
Copy link
Copy Markdown
Member

@tennix tennix commented Apr 27, 2020

What is changed, added or deleted? (Required)

Loader now is deprecated and not maintained anymore, so add a warning to suggest user switch to TiDB Lightning.

Note: this PR also changes the loader.md file encoding from windows format to unix format, that is the new line is changed from CRLF to LF. See here for details (https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

kennytm
kennytm reviewed Apr 27, 2020
View reviewed changes
Comment thread reference/tools/loader.md Outdated
lilin90
lilin90 reviewed Apr 27, 2020
View reviewed changes
Comment thread reference/tools/loader.md Outdated
Comment thread reference/tools/loader.md Outdated
@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Apr 27, 2020
@TomShawn TomShawn assigned ran-huang and toutdesuite and unassigned ran-huang Apr 27, 2020
lilin90
lilin90 approved these changes Apr 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 changed the title reference/tools: Add warning for deprecated loader reference/tools: add warning for deprecated loader Apr 29, 2020
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Apr 29, 2020

@kennytm @WangXiangUSTC PTAL~ Thanks!

kennytm
kennytm reviewed Apr 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 1, 2020

@kennytm, @lilin90, @WangXiangUSTC, PTAL.

1 similar comment
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 3, 2020

@kennytm, @lilin90, @WangXiangUSTC, PTAL.

@kennytm kennytm added status/LGT2 Indicates that a PR has LGTM 2. and removed status/PTAL This PR is ready for reviewing. labels May 3, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 6, 2020

@kennytm, @lilin90, @WangXiangUSTC, PTAL.

@WangXiangUSTC
Copy link
Copy Markdown
Contributor

WangXiangUSTC commented May 6, 2020

LGTM

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

@kennytm, @lilin90, @WangXiangUSTC, PTAL.

@kennytm kennytm merged commit 6eb66ca into pingcap:master May 8, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@tennix @sre-bot
cherry pick pingcap#2904 to release-3.0
45cf03e 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request May 8, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

cherry pick to release-3.0 in PR #3008

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@tennix @lilin90
@WangXiangUSTC @kennytm @sre-bot
reference/tools: add warning for deprecated loader (pingcap#2904)
82680c2 
* Add warning for deprecated loader

* address comment

* Update loader.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>
@sre-bot sre-bot mentioned this pull request May 8, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

cherry pick to release-3.1 in PR #3009

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@tennix @lilin90
@WangXiangUSTC @kennytm @sre-bot
reference/tools: add warning for deprecated loader (pingcap#2904)
51902c6 
* Add warning for deprecated loader

* address comment

* Update loader.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>
@sre-bot sre-bot mentioned this pull request May 8, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

cherry pick to release-4.0 in PR #3010

lichunzhu added a commit that referenced this pull request May 9, 2020
@sre-bot @tennix
@lilin90 @WangXiangUSTC @kennytm @lichunzhu
reference/tools: add warning for deprecated loader (#2904) (#3010)
56ee0e3 
* Add warning for deprecated loader

* address comment

* Update loader.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>

Co-authored-by: Tennix <tennix@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
lichunzhu added a commit that referenced this pull request May 9, 2020
@sre-bot @tennix
@lilin90 @WangXiangUSTC @kennytm @lichunzhu
reference/tools: add warning for deprecated loader (#2904) (#3009)
6eb60f0 
* Add warning for deprecated loader

* address comment

* Update loader.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>

Co-authored-by: Tennix <tennix@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@lichunzhu
Copy link
Copy Markdown
Contributor

lichunzhu commented May 9, 2020

related issue pingcap/tidb-lightning#305

sre-bot added a commit that referenced this pull request May 9, 2020
@sre-bot
reference/tools: add warning for deprecated loader (#2904) (#3008)
9dc84af
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@tennix @lilin90
@WangXiangUSTC @kennytm @rleungx
reference/tools: add warning for deprecated loader (pingcap#2904)
5f6d0c3 
* Add warning for deprecated loader

* address comment

* Update loader.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>
@yikeke yikeke added the size/large Changes of a large size. label Jun 19, 2020
@ireneontheway ireneontheway added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 27, 2020
@ireneontheway ireneontheway mentioned this pull request Aug 27, 2020
Merged
9 tasks
This was referenced Aug 31, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

@lilin90 lilin90 lilin90 approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees

@ireneontheway ireneontheway

Labels

size/large Changes of a large size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.