Skip to content

reference/tools: add warning for deprecated loader (#3747)#3763

Merged
ti-srebot merged 1 commit into
pingcap:release-4.0from
ti-srebot:release-4.0-8ebc1e3b7c4d
Aug 31, 2020
Merged

reference/tools: add warning for deprecated loader (#3747)#3763
ti-srebot merged 1 commit into
pingcap:release-4.0from
ti-srebot:release-4.0-8ebc1e3b7c4d

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

cherry-pick #3747 to release-4.0


What is changed, added or deleted? (Required)

Loader now is deprecated and not maintained anymore, so add a warning to suggest user switch to TiDB Lightning.

Note: this PR also changes the loader.md file encoding from windows format to unix format, that is the new line is changed from CRLF to LF. See here for details (https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Aug 31, 2020
@ti-srebot ti-srebot requested review from TomShawn and tennix August 31, 2020 05:43
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit f5878af into pingcap:release-4.0 Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants