Skip to content

loader: move loader faq to loader overview#3270

Merged
TomShawn merged 8 commits into
pingcap:masterfrom
TomShawn:loader-overview-updatee
Jul 22, 2020
Merged

loader: move loader faq to loader overview#3270
TomShawn merged 8 commits into
pingcap:masterfrom
TomShawn:loader-overview-updatee

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Jul 14, 2020

What is changed, added or deleted? (Required)

  1. add get started for tidb-binlog
  2. move some content about loader to loader-overview.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jul 14, 2020
Comment thread loader-overview.md Outdated

### Reasons

* Both MySQL client and MySQL/TiDB Server have `max_allowed_packet` quotas. If any of the `max_allowed_packet` quotas is violated, the client receives a corresponding error message. Currently, the latest version of Syncer, Loader, DM, and TiDB Server all have a default `max_allowed_packet` quota of `64M`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Both MySQL client and MySQL/TiDB Server have `max_allowed_packet` quotas. If any of the `max_allowed_packet` quotas is violated, the client receives a corresponding error message. Currently, the latest version of Syncer, Loader, DM, and TiDB Server all have a default `max_allowed_packet` quota of `64M`.
* Both MySQL client and MySQL/TiDB Server have `max_allowed_packet` quotas. If any of the `max_allowed_packet` quotas is violated, the client receives a corresponding error message. Currently, the latest version of Loader and TiDB Server all have a default `max_allowed_packet` quota of `64M`.

Comment thread loader-overview.md Outdated

* Both MySQL client and MySQL/TiDB Server have `max_allowed_packet` quotas. If any of the `max_allowed_packet` quotas is violated, the client receives a corresponding error message. Currently, the latest version of Syncer, Loader, DM, and TiDB Server all have a default `max_allowed_packet` quota of `64M`.
* Please use the latest version, or the latest stable version of the tool. See the [download page](/download-ecosystem-tools.md).
* The full data import processing module in Loader or DM does not support splitting `dump sqls` files.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A large chunk of information is missing.


* Loader 的全量数据导入处理模块不支持对 dump sqls 文件进行切分,原因是 Mydumper 采用了最简单的编码实现,正如 Mydumper 代码注释 `/* Poor man's data dump code */` 所言。如果在 Loader 实现文件切分,那么需要在 `TiDB parser` 基础上实现一个完备的解析器才能正确的处理数据切分,但是随之会带来以下的问题:

    * 工作量大

    * 复杂度高,不容易保证正确性

    * 性能的极大降低

Comment thread loader-overview.md Outdated

```
Row bigger than statement_size for xxx
``
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``
```

Comment thread loader-overview.md Outdated

* If a single row of a wide table exceeds 64M, you need to modify and enable the following two configurations:
* Execute `set @@global.max_allowed_packet=134217728` (`134217728 = 128M`) in TiDB Server.
* Add the configuration like `max-allowed-packet=128M` to the Loader configuration file or DB configuration in DM task configuration file, and then restart the progress or task.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add the configuration like `max-allowed-packet=128M` to the Loader configuration file or DB configuration in DM task configuration file, and then restart the progress or task.
* Add `max-allowed-packet=128M` to db configuration in the Loader configuration file according to your situation, and then restart the progress or task.

Comment thread TOC.md
@TomShawn
Copy link
Copy Markdown
Contributor Author

@ran-huang PTAL again, thanks!

Comment thread loader-overview.md Outdated
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
@TomShawn
Copy link
Copy Markdown
Contributor Author

@WangXiangUSTC PTAL

Copy link
Copy Markdown
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 22, 2020
@TomShawn TomShawn merged commit 4405915 into pingcap:master Jul 22, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3364

@TomShawn TomShawn deleted the loader-overview-updatee branch July 22, 2020 02:41
ran-huang pushed a commit that referenced this pull request Jul 22, 2020
* cherry pick #3270 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn mentioned this pull request Aug 5, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants