Skip to content

reference/tools: add warning for deprecated loader#3747

Merged
TomShawn merged 4 commits into
pingcap:masterfrom
ireneontheway:loader-warning
Aug 31, 2020
Merged

reference/tools: add warning for deprecated loader#3747
TomShawn merged 4 commits into
pingcap:masterfrom
ireneontheway:loader-warning

Conversation

@ireneontheway
Copy link
Copy Markdown
Contributor

@ireneontheway ireneontheway commented Aug 27, 2020

What is changed, added or deleted? (Required)

Loader now is deprecated and not maintained anymore, so add a warning to suggest user switch to TiDB Lightning.

Note: this PR also changes the loader.md file encoding from windows format to unix format, that is the new line is changed from CRLF to LF. See here for details (https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.0 status/PTAL This PR is ready for reviewing. labels Aug 27, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 29, 2020

@tennix, @TomShawn, PTAL.

1 similar comment
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 31, 2020

@tennix, @TomShawn, PTAL.

tennix
tennix approved these changes Aug 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 31, 2020

@tennix,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Aug 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
@TomShawn TomShawn merged commit 8ebc1e3 into pingcap:master Aug 31, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 31, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3747 to release-3.0
243bd7f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 31, 2020
Merged
9 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 31, 2020

cherry pick to release-3.0 in PR #3761

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 31, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3747 to release-3.1
f9c33d5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 31, 2020
Merged
9 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 31, 2020

cherry pick to release-3.1 in PR #3762

TomShawn pushed a commit that referenced this pull request Aug 31, 2020
@ti-srebot @ireneontheway
cherry pick #3747 to release-3.1 (#3762)
54e0d81 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 31, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3747 to release-4.0
cd9f6f8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 31, 2020
Merged
9 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 31, 2020

cherry pick to release-4.0 in PR #3763

ti-srebot added a commit that referenced this pull request Aug 31, 2020
@ti-srebot
reference/tools: add warning for deprecated loader (#3747) (#3761)
196c88f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Aug 31, 2020
@ti-srebot
reference/tools: add warning for deprecated loader (#3747) (#3763)
f5878af 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ireneontheway ireneontheway deleted the loader-warning branch September 4, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tennix tennix tennix approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ireneontheway @ti-srebot @tennix @TomShawn