benchmark: Add TPC-H benchmark and update TPC-C benchmark for v4.0 vs v3.0 by JaySon-Huang · Pull Request #3392 · pingcap/docs-cn

JaySon-Huang · 2020-05-28T07:55:16Z

Signed-off-by: JaySon-Huang tshent@qq.com

What is changed, added or deleted? (Required)

Add TPC-H benchmark for v4.0 vs v3.0

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

shuke987 · 2020-05-28T08:06:47Z

LGTM

zz-jason · 2020-05-28T08:03:09Z

+---
+title: TiDB TPC-H 性能对比测试报告 - v4.0 对比 v3.0
+category: benchmark
+draft: true


Suggested change

draft: true

draft: false

should it be false?

See tpcc benchmark doc, its "draft" property is true, I just keep that for consistent.

@shuke987 @lilin90 please help us to confirm whether it should be false.

If the testing results in this doc are ready to publish, then we can remove this draft line. Just keep it when the content is not ready.

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Signed-off-by: JaySon-Huang <tshent@qq.com>

zz-jason

LGTM

…to pr/3392

TomShawn

@JaySon-Huang tpcc 没有测试结果，请添加

JaySon-Huang · 2020-05-28T10:02:44Z

@JaySon-Huang tpcc 没有测试结果，请添加

tpcc 的结果需要由 @innerr @Connor1996 更新

lilin90 · 2020-05-28T10:36:57Z

+---
+title: TiDB TPC-H 性能对比测试报告 - v4.0 对比 v3.0
+category: benchmark
+draft: true


If the testing results in this doc are ready to publish, then we can remove this draft line. Just keep it when the content is not ready.

CaitinChen · 2020-05-28T10:36:51Z

 ### 硬件配置

-| 服务类型   | EC2 类型   |    节点数  |      
+| 服务类型   | EC2 类型   |    节点数  |


叫“节点数”而不是“实例数”？

@CaitinChen PTAL

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Signed-off-by: JaySon-Huang <tshent@qq.com>

JaySon-Huang · 2020-05-28T12:32:19Z

Should we wait for TPC-C / Sysbench benchmark result ready before merging this PR? @shuke987 @zz-jason

TomShawn

LGTM

JaySon-Huang · 2020-05-29T04:50:37Z

Merge this PR with confirmed TPC-H benchmark result. But not showing it in TOC.md by now.

Maybe show it with confirmed TPC-C, Sysbench result later.

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-05-29T04:53:12Z

cherry pick to release-4.0 in PR #3408

* cherry pick #3392 to release-4.0 Signed-off-by: sre-bot <sre-bot@pingcap.com> * Delete TOC.md * Revert "Delete TOC.md" This reverts commit 0b423bd. * remove TPC-H test from TOC * Update TOC.md * Update benchmark/v4.0-performance-benchmarking-with-tpch.md Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

sre-bot added special-week PR from Document Special Week. status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels May 28, 2020

sre-bot requested review from kissmydb and lilin90 May 28, 2020 07:56

zz-jason reviewed May 28, 2020

View reviewed changes

JaySon-Huang changed the base branch from docs-special-week to master May 28, 2020 08:14

JaySon-Huang added 6 commits May 28, 2020 16:15

Add tpch

fa53d3d

Signed-off-by: JaySon-Huang <tshent@qq.com>

Fix check

72fe89a

Signed-off-by: JaySon-Huang <tshent@qq.com>

Fix indents

07e0c54

Signed-off-by: JaySon-Huang <tshent@qq.com>

Fix typo

18af5c5

Signed-off-by: JaySon-Huang <tshent@qq.com>

Fix

9295a18

Signed-off-by: JaySon-Huang <tshent@qq.com>

address comment

18dc2d8

Signed-off-by: JaySon-Huang <tshent@qq.com>

JaySon-Huang force-pushed the tpch_aws branch from 5e01220 to 18dc2d8 Compare May 28, 2020 08:16

apply style for tpc-c

72c0fd7

Signed-off-by: JaySon-Huang <tshent@qq.com>

TomShawn reviewed May 28, 2020

View reviewed changes

JaySon-Huang and others added 3 commits May 28, 2020 16:59

Apply suggestions from code review

470d41a

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

yaml blocks

0b4d2bc

Signed-off-by: JaySon-Huang <tshent@qq.com>

Keep same style for tpcc doc

3d56aba

Signed-off-by: JaySon-Huang <tshent@qq.com>

JaySon-Huang added the needs-cherry-pick-4.0 label May 28, 2020

JaySon-Huang commented May 28, 2020

View reviewed changes

Comment thread benchmark/v4.0-performance-benchmarking-with-tpch.md Outdated

Apply suggestion

c6ed57e

zz-jason approved these changes May 28, 2020

View reviewed changes

TomShawn added 2 commits May 28, 2020 17:53

refine format and layout

6ecdaf2

Merge branch 'tpch_aws' of https://github.com/JaySon-Huang/docs-cn in…

fe21edb

…to pr/3392

TomShawn suggested changes May 28, 2020

View reviewed changes

Update TOC.md

e2d5f28

TomShawn reviewed May 28, 2020

View reviewed changes

Comment thread TOC.md Outdated

lilin90 reviewed May 28, 2020

View reviewed changes

CaitinChen reviewed May 28, 2020

View reviewed changes

JaySon-Huang and others added 2 commits May 28, 2020 20:26

Remove draft property

35ec9ac

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Fix term

1158daf

Signed-off-by: JaySon-Huang <tshent@qq.com>

This comment has been minimized.

Sign in to view

Merge branch 'master' into tpch_aws

4419f07

TomShawn approved these changes May 28, 2020

View reviewed changes

TomShawn added special-week PR from Document Special Week. and removed special-week PR from Document Special Week. labels May 29, 2020

yikeke reviewed May 29, 2020

View reviewed changes

Comment thread benchmark/v4.0-performance-benchmarking-with-tpcc.md

JaySon-Huang removed the special-week PR from Document Special Week. label May 29, 2020

Merge branch 'master' into tpch_aws

548f958

JaySon-Huang merged commit 635e8dd into pingcap:master May 29, 2020

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 29, 2020

cherry pick pingcap#3392 to release-4.0

bcb81cf

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request May 29, 2020

benchmark: Add TPC-H benchmark for v4.0 vs v3.0 (#3392) #3408

Merged

5 tasks

JaySon-Huang deleted the tpch_aws branch May 29, 2020 04:57

TomShawn mentioned this pull request May 29, 2020

remove 4.0 TPC-H from TOC #3409

Merged

5 tasks

TomShawn self-requested a review May 31, 2020 04:14

yikeke added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 1, 2020

yikeke assigned TomShawn Jun 1, 2020

yikeke changed the title ~~benchmark: Add TPC-H benchmark for v4.0 vs v3.0~~ benchmark: Add TPC-H benchmark and update TPC-C benchmark for v4.0 vs v3.0 Jun 1, 2020

TomShawn mentioned this pull request Jun 2, 2020

benchmark, TOC: add 4.0 TPC-H, TPC-C and Sysbench test reports pingcap/docs#2661

Merged

5 tasks

sre-bot mentioned this pull request Jun 5, 2020

benchmark, TOC: add 4.0 TPC-H, TPC-C and Sysbench test reports (#2661) pingcap/docs#2711

Merged

5 tasks

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 19, 2020

Conversation

JaySon-Huang commented May 28, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

shuke987 commented May 28, 2020

Uh oh!

zz-jason May 28, 2020

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zz-jason May 28, 2020

Choose a reason for hiding this comment

Uh oh!

lilin90 May 28, 2020

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang May 28, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zz-jason left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang commented May 28, 2020

Uh oh!

Uh oh!

lilin90 May 28, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CaitinChen May 28, 2020

Choose a reason for hiding this comment

Uh oh!

TomShawn May 28, 2020

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang commented May 28, 2020

Uh oh!

This comment has been minimized.

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JaySon-Huang commented May 29, 2020

Uh oh!

sre-bot commented May 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JaySon-Huang May 28, 2020 •

edited

Loading

TomShawn left a comment •

edited

Loading