Skip to content

remove 4.0 TPC-H from TOC#3409

Merged
yikeke merged 2 commits into
pingcap:masterfrom
TomShawn:remove-4.0-tpch-inTOC
May 29, 2020
Merged

remove 4.0 TPC-H from TOC#3409
yikeke merged 2 commits into
pingcap:masterfrom
TomShawn:remove-4.0-tpch-inTOC

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented May 29, 2020

What is changed, added or deleted? (Required)

Remove 4.0 vs 3.0 TPC-H test report from TOC.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added the translation/no-need No need to translate this PR. label May 29, 2020
@TomShawn TomShawn requested a review from JaySon-Huang May 29, 2020 05:59
Copy link
Copy Markdown
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn requested a review from yikeke May 29, 2020 06:06
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented May 29, 2020

So draft: true should be added back again? @TomShawn @JaySon-Huang

@JaySon-Huang
Copy link
Copy Markdown
Contributor

JaySon-Huang commented May 29, 2020

I think publishing TPC-H/TPC-C/Sysbench benchmark results at the same time is better. So temporarily remove that from TOC.md. @yikeke

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented May 29, 2020

I think publishing TPC-H/TPC-C/Sysbench benchmark results at the same time is better. So temporarily remove that from TOC.md. @yikeke

ok

Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit ab8db7f into pingcap:master May 29, 2020
@TomShawn TomShawn deleted the remove-4.0-tpch-inTOC branch May 29, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants