Add more Dashboard docs#3440
Merged
Merged
Conversation
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
yikeke
requested review from
TomShawn and
lilin90
and removed request for
TomShawn
yikeke
added
needs-cherry-pick-4.0
translation/doing
Signed-off-by: Breezewish <me@breeswish.org>
5 tasks
Member
|
I'll review this PR on Jun 3. |
Signed-off-by: Breezewish <me@breeswish.org>
lilin90
reviewed
Jun 3, 2020
Comment on lines
+98
to
+120
| > 修改完成后的配置文件类似于： | ||
| > | ||
| > ```yaml | ||
| > server_configs: | ||
| > pd: | ||
| > dashboard.public-path-prefix: /foo | ||
| > global: | ||
| > user: tidb | ||
| > ... | ||
| > ``` | ||
| > | ||
| > 或 | ||
| > | ||
| > ```yaml | ||
| > monitored: | ||
| > ... | ||
| > server_configs: | ||
| > tidb: ... | ||
| > tikv: ... | ||
| > pd: | ||
| > dashboard.public-path-prefix: /foo | ||
| > ... | ||
| > ``` |
Member
There was a problem hiding this comment.
The > character is unnecessary? Suggest removing them.
Member
Author
There was a problem hiding this comment.
它们主要是用作补充说明，便于用户校对修改是否正确，应该问题不大
Member
There was a problem hiding this comment.
@breeswish 通常建议格式尽量简单，以确保官网解析正常。可以观察下，如果在官网格式错乱了，就请删掉这些字符。 @TomShawn 英文版里不必留这些字符。
Member
|
@breeswish I added a commit 89607b4 to update wording and format. FYI. |
breezewish
commented
Jun 3, 2020
breezewish
commented
Jun 3, 2020
Member
Author
breezewish
left a comment
breezewish
left a comment
There was a problem hiding this comment.
Thanks for the help! Mostly LGTM
Member
Author
|
@HunDunDM PTAL |
5 tasks
HunDunDM
reviewed
Jun 4, 2020
Co-authored-by: 混沌DM <hundundm@gmail.com>
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
HunDunDM
approved these changes
Jun 4, 2020
TomShawn
reviewed
Jun 4, 2020
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
lilin90
reviewed
Jun 4, 2020
Signed-off-by: Breezewish <me@breeswish.org>
Member
|
/merge |
sre-bot
added
the
status/can-merge
Contributor
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Jun 4, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #3502 |
sre-bot
added a commit
that referenced
this pull request
Jun 5, 2020
5 tasks
5 tasks
TomShawn
added
translation/done
This was referenced Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Breezewish me@breeswish.org
What is changed, added or deleted? (Required)
Added the following new documentations for TiDB Dashboard, to make content more complete:
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?