Skip to content

Add Dashboard Access and Profiling Page#2655

Merged
sre-bot merged 11 commits into
pingcap:masterfrom
TomShawn:dashboard-access
Jun 8, 2020
Merged

Add Dashboard Access and Profiling Page#2655
sre-bot merged 11 commits into
pingcap:masterfrom
TomShawn:dashboard-access

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Jun 1, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add TiDB Dashboard Overview and Instance Profiling Page.

I'll add all TiDB Dashboard related documents in TOC when most of them are merged into docs.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/WIP This PR is still working in progress. special-week PR from Document Special Week. labels Jun 1, 2020
@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. and removed status/WIP This PR is still working in progress. labels Jun 2, 2020
@TomShawn TomShawn requested review from breezewish and yikeke June 2, 2020 08:18
@TomShawn TomShawn marked this pull request as ready for review June 2, 2020 08:18
breezewish
breezewish reviewed Jun 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pingcap/docs-cn#3440 made some little changes to the Access page. Do we need to wait for that PR being merged first?

@TomShawn TomShawn changed the title Add Dashboard Access, Overview and Profiling Page Add Dashboard Access and Profiling Page Jun 2, 2020
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Jun 2, 2020

pingcap/docs-cn#3440 made some little changes to the Access page. Do we need to wait for that PR being merged first?

OK

@yikeke yikeke requested review from lilin90 and removed request for yikeke June 3, 2020 05:22
@TomShawn TomShawn mentioned this pull request Jun 3, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 4, 2020

@breeswish, @lilin90, PTAL.

@TomShawn TomShawn mentioned this pull request Jun 4, 2020
Merged
5 tasks
This was referenced Jun 5, 2020
Merged
Merged
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 6, 2020

@breeswish, @lilin90, PTAL.

@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Jun 8, 2020

@breeswish I'll create another PR to align the changes made in pingcap/docs-cn#3440. Can we merge this PR first? coz several Dashboard en PRs cannot be merged until this one is merged. All changes of images are in this PR. PTAL again, thanks!

breezewish
breezewish reviewed Jun 8, 2020
View reviewed changes
Comment thread dashboard/dashboard-access.md Outdated
Comment thread dashboard/dashboard-access.md Outdated
Comment thread dashboard/dashboard-access.md Outdated
Comment thread dashboard/dashboard-access.md Outdated
Comment thread dashboard/dashboard-access.md Outdated
Comment thread dashboard/dashboard-profiling.md Outdated
Comment thread dashboard/dashboard-profiling.md Outdated
@TomShawn @breezewish
Apply suggestions from code review
442d652 
Co-authored-by: Wenxuan <hi@breeswish.org>
lilin90
lilin90 reviewed Jun 8, 2020
View reviewed changes
Comment thread dashboard/dashboard-access.md
Comment on lines +11 to +13
> **Note:**
>
> If you have deployed multiple PD components in your cluster, you can use the address of only one PD component to access TiDB Dashboard, because the Dashboard operates on only one PD component. If you access via other PD components, your browser is redirected to that PD component. Therefore, if the firewall is not configured for this instance on which PD operates, you might not be able to access TiDB Dashboard.
Copy link
Copy Markdown
Member

@lilin90 lilin90 Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the latest Chinese version and update it.

Copy link
Copy Markdown
Contributor Author

@TomShawn TomShawn Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated part contains links of several documents added in pingcap/docs-cn#3440. For convenience, I'll update the change made to dashboard-access.md in another PR together with those newly added documents.

Copy link
Copy Markdown
Member

@lilin90 lilin90 Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

Comment thread dashboard/dashboard-access.md Outdated
Comment thread dashboard/dashboard-access.md Outdated
Comment thread dashboard/dashboard-access.md Outdated
Comment thread dashboard/dashboard-access.md Outdated
@TomShawn @lilin90
address comments from lilian
bf489ce 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90
lilin90 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit 0e601f0 into pingcap:master Jun 8, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 8, 2020
@TomShawn @sre-bot
cherry pick pingcap#2655 to release-4.0
5310e39 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-4.0 in PR #2731

TomShawn added a commit that referenced this pull request Jun 8, 2020
@sre-bot @TomShawn
cherry pick #2655 to release-4.0 (#2731)
90486a0 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the dashboard-access branch June 8, 2020 09:46
This was referenced Jun 9, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

No one assigned

Labels

special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @sre-bot @breezewish @lilin90