Skip to content

add descriptions about binding source#3449

Merged
sre-bot merged 3 commits into
pingcap:masterfrom
danmay319:pull3448
Jun 2, 2020
Merged

add descriptions about binding source#3449
sre-bot merged 3 commits into
pingcap:masterfrom
danmay319:pull3448

Conversation

@danmay319
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@danmay319 danmay319 requested review from lzmhhh123 and yikeke June 2, 2020 06:48
@yikeke yikeke requested review from zz-jason and removed request for zz-jason June 2, 2020 06:48
@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 2, 2020
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmay319 danmay319 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2020
| update_time | 更新时间 |
| charset | 字符集 |
| collation | 排序规则 |
| source | 创建方式 |
Copy link
Copy Markdown
Member

@zz-jason zz-jason Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

举个例子吧,分别描述下每种 source 可能出现的方式

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment addressed @zz-jason

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 2, 2020

Your auto merge job has been accepted, waiting for:

  • 3448

@zz-jason
Copy link
Copy Markdown
Member

zz-jason commented Jun 2, 2020

@lawyerphx 这个功能应该还没有带到 4.0 中,需要 cherry-pick 下代码

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 2, 2020

/run-all-tests

@sre-bot sre-bot merged commit 242c6a3 into pingcap:master Jun 2, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 2, 2020

cherry pick to release-4.0 in PR #3453

@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL binding should record how bindings are created.

5 participants