Skip to content

add descriptions about binding source#2981

Merged
yikeke merged 3 commits into
pingcap:masterfrom
danmay319:add_source
Jun 22, 2020
Merged

add descriptions about binding source#2981
yikeke merged 3 commits into
pingcap:masterfrom
danmay319:add_source

Conversation

@danmay319
Copy link
Copy Markdown
Contributor

@danmay319 danmay319 commented Jun 22, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@danmay319 danmay319 requested review from lzmhhh123 and yikeke June 22, 2020 03:39
@danmay319 danmay319 added size/small Changes of a small size. needs-cherry-pick-4.0 labels Jun 22, 2020
lzmhhh123
lzmhhh123 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2020
yikeke
yikeke reviewed Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread sql-plan-management.md Outdated
Comment thread sql-statements/sql-statement-show-bindings.md Outdated
danmay319 and others added 2 commits June 22, 2020 12:24
@danmay319 @yikeke
Update sql-plan-management.md
6434535 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@danmay319 @yikeke
Update sql-statements/sql-statement-show-bindings.md
1696570 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@danmay319 danmay319 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2020
@danmay319 danmay319 requested a review from yikeke June 22, 2020 04:26
yikeke
yikeke approved these changes Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit f67ca86 into pingcap:master Jun 22, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 22, 2020
@danmay319 @ti-srebot
cherry pick pingcap#2981 to release-4.0
3e8a83c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 22, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 22, 2020

cherry pick to release-4.0 in PR #2982

yikeke pushed a commit that referenced this pull request Jun 22, 2020
@ti-srebot @danmay319
cherry pick #2981 to release-4.0 (#2982)
7a50fea 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lawyerphx <pheqx@qq.com>
@lilin90 lilin90 added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SQL binding should record how bindings are created.

5 participants

@danmay319 @ti-srebot @lzmhhh123 @yikeke @lilin90