Skip to content

tikv: update --adverties-status-addr#3602

Merged
TomShawn merged 4 commits into
pingcap:masterfrom
overvenus:add-advertise-status-addr
Jun 11, 2020
Merged

tikv: update --adverties-status-addr#3602
TomShawn merged 4 commits into
pingcap:masterfrom
overvenus:add-advertise-status-addr

Conversation

@overvenus
Copy link
Copy Markdown
Member

@overvenus overvenus commented Jun 11, 2020

What is changed, added or deleted? (Required)

Update tikv command line flag --advertise-status-addr.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@overvenus
tikv: update --adverties-status-addr
cb8cb1a 
Signed-off-by: Neil Shen <overvenus@gmail.com>
TomShawn
TomShawn reviewed Jun 11, 2020
View reviewed changes
Comment thread command-line-flags-for-tikv-configuration.md Outdated
@overvenus @TomShawn
Update command-line-flags-for-tikv-configuration.md
f37de49 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Jun 11, 2020
View reviewed changes
Comment thread command-line-flags-for-tikv-configuration.md Outdated
Comment thread command-line-flags-for-tikv-configuration.md Outdated
overvenus and others added 2 commits June 11, 2020 16:08
@overvenus @TomShawn
Update command-line-flags-for-tikv-configuration.md
3e52451 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@overvenus @TomShawn
Update command-line-flags-for-tikv-configuration.md
3e8f352 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn self-assigned this Jun 11, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 11, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 11, 2020

@overvenus Please also involve a technical review.

@overvenus overvenus requested a review from NingLin-P June 11, 2020 08:10
NingLin-P
NingLin-P approved these changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

TomShawn
TomShawn approved these changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit 6baa934 into pingcap:master Jun 11, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 11, 2020
@overvenus @sre-bot
cherry pick pingcap#3602 to release-4.0
bb3f127 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 11, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-4.0 in PR #3603

sre-bot added a commit that referenced this pull request Jun 11, 2020
@sre-bot @overvenus
tikv: update --adverties-status-addr (#3602) (#3603)
58e17c1 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
@uglyengineer uglyengineer mentioned this pull request Jun 12, 2020
Closed
13 tasks
@TomShawn TomShawn mentioned this pull request Jun 17, 2020
Merged
5 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 17, 2020
This was referenced Jul 2, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@NingLin-P NingLin-P NingLin-P approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@overvenus @TomShawn @sre-bot @NingLin-P