Skip to content

Update command-line-flags-for-tikv-configuration.md#2943

Merged
lilin90 merged 5 commits into
pingcap:masterfrom
TomShawn:update-tikv-configsfi
Jul 2, 2020
Merged

Update command-line-flags-for-tikv-configuration.md#2943
lilin90 merged 5 commits into
pingcap:masterfrom
TomShawn:update-tikv-configsfi

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Jun 17, 2020

What is changed, added or deleted? (Required)

Update command-line-flags-for-tikv-configuration.md

Changes in pingcap/docs-cn#3602 are not applicable to v3.1. I'll manually remove the changes in the cp PR.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.1 special-week PR from Document Special Week. labels Jun 17, 2020
@TomShawn TomShawn marked this pull request as ready for review June 18, 2020 04:23
@TomShawn TomShawn requested review from nolouch, overvenus and yikeke June 18, 2020 04:24
@yikeke yikeke requested a review from CaitinChen June 22, 2020 02:22
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 22, 2020

Please help review this PR. @CaitinChen

@yikeke yikeke removed their request for review June 22, 2020 02:23
Comment thread command-line-flags-for-tikv-configuration.md Outdated
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 removed the request for review from CaitinChen July 2, 2020 06:45
@lilin90 lilin90 added the size/small Changes of a small size. label Jul 2, 2020
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 2, 2020

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

Sorry @lilin90, you don't have permission to trigger auto merge event on this branch. The number of LGTM for this PR is 0 while it needs 2 at least

@lilin90 lilin90 added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 2, 2020
@lilin90 lilin90 merged commit ac39a14 into pingcap:master Jul 2, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@TomShawn TomShawn deleted the update-tikv-configsfi branch July 2, 2020 06:59
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.1 in PR #3114

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3115

ti-srebot added a commit that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/small Changes of a small size. special-week PR from Document Special Week. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants