Skip to content

add explaination about last_plan_from_binding#3702

Merged
ti-srebot merged 6 commits into
pingcap:masterfrom
Reminiscent:last_statement_found_in_spm
Jul 30, 2020
Merged

add explaination about last_plan_from_binding#3702
ti-srebot merged 6 commits into
pingcap:masterfrom
Reminiscent:last_statement_found_in_spm

Conversation

@Reminiscent
Copy link
Copy Markdown
Contributor

@Reminiscent Reminiscent commented Jun 18, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

add explaination about a new system variable last_plan_from_binding to tidb-specific-variables.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@Reminiscent Reminiscent requested review from JaySon-Huang and removed request for JaySon-Huang June 18, 2020 07:35
TomShawn
TomShawn reviewed Jun 18, 2020
View reviewed changes
Comment thread tidb-specific-system-variables.md Outdated
@TomShawn TomShawn requested review from XuHuaiyu and qw4990 June 18, 2020 14:05
@TomShawn TomShawn self-assigned this Jun 18, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 18, 2020
XuHuaiyu
XuHuaiyu reviewed Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 29, 2020

@XuHuaiyu,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Jul 30, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 30, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 43b0531 into pingcap:master Jul 30, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 30, 2020
@Reminiscent @ti-srebot
cherry pick pingcap#3702 to release-4.0
7f6d02f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 30, 2020

cherry pick to release-4.0 in PR #4113

ti-srebot added a commit that referenced this pull request Jul 30, 2020
@ti-srebot @Reminiscent
add explaination about last_plan_from_binding (#3702) (#4113)
34893a5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Chengpeng Yan <41809508+Reminiscent@users.noreply.github.com>
@TomShawn TomShawn assigned Joyinqin and unassigned TomShawn Aug 10, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 17, 2020
Merged
9 tasks
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Aug 17, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 17, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Aug 17, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Aug 17, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2020
Merged
9 tasks
@TomShawn TomShawn mentioned this pull request Feb 19, 2021
Merged
10 tasks
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2021
Merged
10 tasks
@Reminiscent Reminiscent deleted the last_statement_found_in_spm branch August 5, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 Awaiting requested review from qw4990

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Reminiscent @ti-srebot @Joyinqin @XuHuaiyu @TomShawn