Skip to content

system-variable: add explaination about last_plan_from_binding#3673

Merged
ti-srebot merged 5 commits into
pingcap:masterfrom
Joyinqin:variables
Aug 20, 2020
Merged

system-variable: add explaination about last_plan_from_binding#3673
ti-srebot merged 5 commits into
pingcap:masterfrom
Joyinqin:variables

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Aug 17, 2020

What is changed, added or deleted? (Required)

add explanation about a new system variable last_plan_from_binding.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Aug 17, 2020

/label needs-cherry-pick-4.0, translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Aug 17, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Aug 17, 2020

/cc TomShawn, Reminiscent

@TomShawn TomShawn requested review from TomShawn and XuHuaiyu August 17, 2020 05:40
TomShawn
TomShawn reviewed Aug 17, 2020
View reviewed changes
Comment thread system-variables.md Outdated
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Aug 17, 2020
Joyinqin and others added 2 commits August 17, 2020 22:13
@Joyinqin
Merge branch 'master' into variables
0083cac
@Joyinqin @TomShawn
Apply suggestions from code review
72eb888 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 20, 2020

@TomShawn, @nullnotnil, @XuHuaiyu, PTAL.

@XuHuaiyu
Copy link
Copy Markdown
Contributor

XuHuaiyu commented Aug 20, 2020

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 20, 2020

@XuHuaiyu,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Aug 20, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 20, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 158d470 into pingcap:master Aug 20, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 20, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3673 to release-4.0
26be43a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2020
Merged
9 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 20, 2020

cherry pick to release-4.0 in PR #3699

TomShawn pushed a commit that referenced this pull request Aug 20, 2020
@ti-srebot @Joyinqin
cherry pick #3673 to release-4.0 (#3699)
77ce39f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@Joyinqin Joyinqin deleted the variables branch August 21, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

2 more reviewers

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joyinqin @ti-srebot @XuHuaiyu @TomShawn