Skip to content

br: add use constraint with CDC and drainer#3750

Merged
TomShawn merged 8 commits into
pingcap:masterfrom
YuJuncen:br-and-cdc
Aug 3, 2020
Merged

br: add use constraint with CDC and drainer#3750
TomShawn merged 8 commits into
pingcap:masterfrom
YuJuncen:br-and-cdc

Conversation

@YuJuncen
Copy link
Copy Markdown
Contributor

@YuJuncen YuJuncen commented Jun 22, 2020

What is changed, added or deleted? (Required)

现今 CDC 和 Drainer 无法同步 BR 所恢复的数据,同时 BR 恢复到上游集群可能会让 CDC / Drainer 工作异常。

于是在文档中标注出来。

Version-specific changes to release-3.1 are needed. See #4184.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

Comment thread br/backup-and-restore-faq.md Outdated
Comment thread br/backup-and-restore-faq.md Outdated
Comment thread br/backup-and-restore-faq.md Outdated
Comment thread br/backup-and-restore-faq.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

@YuJuncen Please also involve a technical review.

@TomShawn TomShawn added the size/small Changes of a small size. label Jun 22, 2020
Comment thread br/backup-and-restore-tool.md Outdated
@TomShawn TomShawn added needs-cherry-pick-3.1 translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 22, 2020
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@YuJuncen
Copy link
Copy Markdown
Contributor Author

@3pointer @leoppro PTAL~

Comment thread br/backup-and-restore-faq.md Outdated
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 29, 2020
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 31, 2020
Copy link
Copy Markdown
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@3pointer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn merged commit f839d57 into pingcap:master Aug 3, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.1 in PR #4151

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #4152

ti-srebot added a commit that referenced this pull request Aug 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
YuJuncen added a commit to YuJuncen/docs-cn that referenced this pull request Aug 4, 2020
* br: add use constraint with CDC and drainer

* br: fix a bad format

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update backup-and-restore-faq.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Aug 4, 2020
)

* br: add use constraint with CDC and drainer (#3750)

* br: add use constraint with CDC and drainer

* br: fix a bad format

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update backup-and-restore-faq.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* br: remove a dead link

* br: remove mention to TiCDC

* delete 4.0-specific content

* Update backup-and-restore-faq.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Aug 4, 2020
@yikeke yikeke assigned Joyinqin and unassigned ireneontheway Sep 1, 2020
@TomShawn TomShawn mentioned this pull request Sep 4, 2020
9 tasks
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Sep 6, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 6, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Sep 6, 2020

/unlabel translation/doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants