Skip to content

br: add use constraint with TiCDC and Drainer#3839

Merged
TomShawn merged 7 commits into
pingcap:masterfrom
Joyinqin:br-faq
Sep 8, 2020
Merged

br: add use constraint with TiCDC and Drainer#3839
TomShawn merged 7 commits into
pingcap:masterfrom
Joyinqin:br-faq

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Sep 6, 2020

What is changed, added or deleted? (Required)

Add use constraint with TiCDC and Drainer.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Sep 6, 2020

/label needs-cherry-pick-3.1, needs-cherry-pick-4.0, size/small, version-specific-changes-required

@ti-srebot ti-srebot added needs-cherry-pick-3.1 size/small Changes of a small size. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Sep 6, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Sep 6, 2020

/label translation/from-docs-cn

@ti-srebot ti-srebot added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Sep 6, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Sep 6, 2020

/cc TomShawn, YuJuncen

Comment thread br/backup-and-restore-faq.md Outdated
Comment thread br/backup-and-restore-faq.md Outdated
Comment thread br/backup-and-restore-faq.md Outdated
Comment thread br/backup-and-restore-faq.md Outdated
Comment thread br/backup-and-restore-faq.md Outdated
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2020
@YuJuncen
Copy link
Copy Markdown
Contributor

YuJuncen commented Sep 8, 2020

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@YuJuncen,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit 04715f3 into pingcap:master Sep 8, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 8, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.1 in PR #3848

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 8, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3849

ti-srebot added a commit that referenced this pull request Sep 8, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Sep 8, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@Joyinqin Joyinqin deleted the br-faq branch September 8, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants