Skip to content

mysql-compatibility: Improve MySQL Compatibility#4024

Merged
ti-srebot merged 8 commits into
pingcap:masterfrom
TomShawn:mysqk-combatibilty
Aug 6, 2020
Merged

mysql-compatibility: Improve MySQL Compatibility#4024
ti-srebot merged 8 commits into
pingcap:masterfrom
TomShawn:mysqk-combatibilty

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Jul 21, 2020 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

This improves some aspects of describing MySQL compatibility.

security issues (such as SELECT INTO OUTFILE) is not translated according to https://github.com/pingcap/docs/pull/3192/files#diff-7028919502ad5a35697a652366fdafadR12.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-4.0 labels Jul 21, 2020
@TomShawn TomShawn requested review from kissmydb, yikeke and zz-jason July 21, 2020 12:38
TomShawn
TomShawn commented Jul 22, 2020
View reviewed changes
Comment thread mysql-compatibility.md Outdated
@TomShawn TomShawn marked this pull request as draft July 22, 2020 03:27
TomShawn
TomShawn commented Jul 22, 2020
View reviewed changes
Comment thread sql-statements/sql-statement-analyze-table.md Outdated
@TomShawn TomShawn marked this pull request as ready for review July 22, 2020 03:32
@yikeke yikeke requested review from lilin90 and removed request for yikeke July 22, 2020 10:03
zz-jason
zz-jason approved these changes Jul 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2020
lilin90
lilin90 reviewed Jul 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the correctness of some original descriptions and my comments.

Comment thread mysql-compatibility.md Outdated
Comment thread mysql-compatibility.md Outdated
Comment thread mysql-compatibility.md Outdated
Comment thread mysql-compatibility.md Outdated
Comment thread mysql-compatibility.md Outdated
Comment thread mysql-compatibility.md Outdated
Comment thread sql-statements/sql-statement-analyze-table.md Outdated
Comment thread sql-statements/sql-statement-analyze-table.md Outdated
@lilin90 lilin90 added status/require-change Needs the author to address comments. size/medium Changes of a medium size. labels Jul 28, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 30, 2020

@TomShawn, please update your pull request.

@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Jul 30, 2020

@lilin90 Comments are addressed, PTAL again, thanks!

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 1, 2020

@TomShawn, please update your pull request.

@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Aug 3, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 3, 2020

@TomShawn, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 5, 2020

@zz-jason, @lilin90, @kissmydb, PTAL.

lilin90
lilin90 approved these changes Aug 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 6, 2020
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Aug 6, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 6, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 32eed4a into pingcap:master Aug 6, 2020
@TomShawn TomShawn deleted the mysqk-combatibilty branch August 6, 2020 06:24
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 6, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4024 to release-4.0
3bbc2be 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 6, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 6, 2020

cherry pick to release-4.0 in PR #4214

ti-srebot added a commit that referenced this pull request Aug 7, 2020
@ti-srebot @TomShawn
mysql-compatibility: Improve MySQL Compatibility (#4024) (#4214)
6973600 
* cherry pick #4024 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@kissmydb kissmydb Awaiting requested review from kissmydb

+1 more reviewer

@zz-jason zz-jason zz-jason approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @ti-srebot @lilin90 @zz-jason