Skip to content

mysql-compatibility: Improve MySQL Compatibility#3151

Merged
ti-srebot merged 6 commits into
masterfrom
unknown repository
Jul 6, 2020
Merged

mysql-compatibility: Improve MySQL Compatibility#3151
ti-srebot merged 6 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 3, 2020

What is changed, added or deleted? (Required)

This improves some aspects of describing MySQL compatibility.

I thought it was important to point to GitHub issues on some of the more common feature requests, and explain in more detailed context than ROI why some features may not be available.

The DDL section was hard to read, so I reformatted it to focus on what was missing versus what was supported.

The ANALYZE TABLE update fixes #2478

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

fixes #2478 + some additional changes.

Nullnotnil added 2 commits July 3, 2020 08:30
Better explain differences in DDL, ANALYZE TABLE, why features may not
be offered.
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Jul 3, 2020
@ghost ghost changed the title Improve MySQL Compatibility mysql-compatibility: Improve MySQL Compatibility Jul 3, 2020
@ghost ghost mentioned this pull request Jul 3, 2020
5 tasks
Copy link
Copy Markdown
Contributor

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@kolbe, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@TomShawn TomShawn added needs-cherry-pick-4.0 size/large Changes of a large size. translation/doing This PR's assignee is translating this PR. labels Jul 6, 2020
Comment thread mysql-compatibility.md Outdated
Comment thread mysql-compatibility.md Outdated
Comment thread sql-statements/sql-statement-analyze-table.md Outdated
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@lilin90,Thanks for your review.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2020
@lilin90 lilin90 added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 6, 2020
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 6, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 061857f into pingcap:master Jul 6, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3174

ghost pushed a commit that referenced this pull request Jul 6, 2020
* cherry pick #3151 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update mysql-compatibility.md

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
@ghost ghost mentioned this pull request Jul 7, 2020
5 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. size/medium Changes of a medium size. and removed translation/doing This PR's assignee is translating this PR. size/large Changes of a large size. labels Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document ANALYZE TABLE incompatibilities with MySQL

4 participants