sql-mode: update compatibility · Pull Request #3192 · pingcap/docs

ghost · 2020-07-07T13:51:21Z

What is changed, added or deleted? (Required)

Also addresses a minor issue in mysql-compatibility where in my #3151 I said that SELECT INTO OUTFILE may not be implemented, but it since has been.

I also propose moving "Compatibility -> MySQL Compatibility" to "MySQL Compatibility" in the menu, to simplify navigation, and add myself as a reviewer to mysql compatibility areas.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

yikeke · 2020-07-08T01:33:46Z

Note: mysql-compatibility.md is very different in versions below 4.0. You might need to resolve conflicts when this PR is cherry-picked to the lower versions.

ghost · 2020-07-08T01:50:27Z

Note: mysql-compatibility.md is very different in versions below 4.0. You might need to resolve conflicts when this PR is cherry-picked to the lower versions.

Yes, that's my plan :-)

ti-srebot · 2020-07-10T01:35:06Z

@zz-jason, @scsldb, @kissmydb, @yikeke, PTAL.

kissmydb · 2020-07-10T10:49:32Z

  + [Basic Features](/basic-features.md)
-  + Compatibility
-    + [MySQL Compatibility](/mysql-compatibility.md)
+  + [MySQL Compatibility](/mysql-compatibility.md)


In the future，maybe have other DB compatibility，so，i think just leave it as it is

If that happens in the future, we update the TOC and change it back :-)

zz-jason

LGTM

ti-srebot · 2020-07-10T10:59:45Z

@zz-jason,Thanks for your review.

zz-jason · 2020-07-10T11:01:32Z


 TiDB is fully compatible with the MySQL 5.7 protocol and the common features and syntax of MySQL 5.7. The ecosystem tools for MySQL 5.7 (PHPMyAdmin, Navicat, MySQL Workbench, mysqldump, and Mydumper/myloader) and the MySQL client can be used for TiDB.

-However, some features of MySQL are not supported. This could be because there is now a better way to solve the problem (such as XML functions superceded by JSON), security issues (such as `SELECT INTO OUTFILE`), or a lack of current demand versus effort required (such as stored procedures and functions). Some features might also be difficult to implement as a distributed system.


select into outfile is supported in TiDB 4.0, we'd better not backport this PR to release 2.1, 3.0, and 3.1.

Understood. The 2.1-3.0 docs will still say this feature is not supported (it's further down in the document). What is removed is an explanation of why we will not add certain features such as this one (which becomes confusing, since it was added in a later version).

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-10T11:28:34Z

cherry pick to release-2.1 in PR #3233

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-10T11:29:22Z

cherry pick to release-3.0 in PR #3234

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-10T11:30:08Z

cherry pick to release-3.1 in PR #3235

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-10T11:30:57Z

cherry pick to release-4.0 in PR #3236

* cherry pick #3192 to release-3.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Update TOC.md * Update assign-by-files.yml * Delete assign-by-files.yml * Update mysql-compatibility.md Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>

* cherry pick #3192 to release-3.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Delete assign-by-files.yml * Update TOC.md * Update mysql-compatibility.md Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>

* cherry pick #3192 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Delete assign-by-files.yml Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>

sql-mode: update compatibility

81a32c2

ghost added needs-cherry-pick-2.1 labels Jul 7, 2020

yikeke requested review from kissmydb, scsldb, yikeke and zz-jason July 8, 2020 01:31

yikeke added status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 8, 2020

Merge branch 'master' into mysql-compat

76e6c56

kissmydb reviewed Jul 10, 2020

View reviewed changes

zz-jason reviewed Jul 10, 2020

View reviewed changes

ti-srebot approved these changes Jul 10, 2020

View reviewed changes

ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020

zz-jason reviewed Jul 10, 2020

View reviewed changes

Merge branch 'master' into mysql-compat

a38d350

ghost merged commit ab766b1 into pingcap:master Jul 10, 2020

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 10, 2020

cherry pick pingcap#3192 to release-2.1

22b9134

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 10, 2020

sql-mode: update compatibility (#3192) #3233

Closed

5 tasks

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 10, 2020

cherry pick pingcap#3192 to release-3.0

ce8b270

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 10, 2020

sql-mode: update compatibility (#3192) #3234

Merged

5 tasks

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 10, 2020

cherry pick pingcap#3192 to release-3.1

380a83e

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 10, 2020

sql-mode: update compatibility (#3192) #3235

Merged

5 tasks

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 10, 2020

cherry pick pingcap#3192 to release-4.0

4de050d

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 10, 2020

sql-mode: update compatibility (#3192) #3236

Merged

5 tasks

yikeke added translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 20, 2020

yikeke assigned TomShawn Jul 20, 2020

This was referenced Jul 22, 2020

mysql-compatibility: Improve MySQL Compatibility pingcap/docs-cn#4024

Merged

sql-mode: update compatibility pingcap/docs-cn#4027

Merged

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 22, 2020

This was referenced Jul 28, 2020

sql-mode: update compatibility (#4027) pingcap/docs-cn#4078

Merged

sql-mode: update compatibility (#4027) pingcap/docs-cn#4079

Merged

sql-mode: update compatibility (#4027) pingcap/docs-cn#4080

Merged

TomShawn removed the needs-cherry-pick-2.1 label Jul 28, 2020

This pull request was closed.


		TiDB is fully compatible with the MySQL 5.7 protocol and the common features and syntax of MySQL 5.7. The ecosystem tools for MySQL 5.7 (PHPMyAdmin, Navicat, MySQL Workbench, mysqldump, and Mydumper/myloader) and the MySQL client can be used for TiDB.

		However, some features of MySQL are not supported. This could be because there is now a better way to solve the problem (such as XML functions superceded by JSON), security issues (such as `SELECT INTO OUTFILE`), or a lack of current demand versus effort required (such as stored procedures and functions). Some features might also be difficult to implement as a distributed system.

Conversation

ghost commented Jul 7, 2020 • edited by TomShawn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

yikeke commented Jul 8, 2020

Uh oh!

ghost commented Jul 8, 2020

Uh oh!

ti-srebot commented Jul 10, 2020

Uh oh!

kissmydb Jul 10, 2020

Choose a reason for hiding this comment

Uh oh!

ghost Jul 10, 2020

Choose a reason for hiding this comment

Uh oh!

zz-jason left a comment

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Jul 10, 2020

Uh oh!

zz-jason Jul 10, 2020

Choose a reason for hiding this comment

Uh oh!

ghost Jul 10, 2020

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Jul 10, 2020

Uh oh!

ti-srebot commented Jul 10, 2020

Uh oh!

ti-srebot commented Jul 10, 2020

Uh oh!

ti-srebot commented Jul 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ghost commented Jul 7, 2020 •

edited by TomShawn

Loading