sql-mode: update compatibility (#3192)#3235
Merged
4 commits merged intoJul 10, 2020
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
ti-srebot
added
status/PTAL
ghost
self-requested a review
ghost
approved these changes
Jul 10, 2020
Contributor
Author
|
@nullnotnil, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack). |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #3192 to release-3.1
What is changed, added or deleted? (Required)
Fixes #1768
Also addresses a minor issue in mysql-compatibility where in my #3151 I said that
SELECT INTO OUTFILEmay not be implemented, but it since has been.I also propose moving "Compatibility -> MySQL Compatibility" to "MySQL Compatibility" in the menu, to simplify navigation, and add myself as a reviewer to mysql compatibility areas.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?