Skip to content

mysql-compatibility: Improve MySQL Compatibility (#3151)#3174

Merged
3 commits merged into
pingcap:release-4.0from
ti-srebot:release-4.0-061857f369ec
Jul 6, 2020
Merged

mysql-compatibility: Improve MySQL Compatibility (#3151)#3174
3 commits merged into
pingcap:release-4.0from
ti-srebot:release-4.0-061857f369ec

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

cherry-pick #3151 to release-4.0


What is changed, added or deleted? (Required)

This improves some aspects of describing MySQL compatibility.

I thought it was important to point to GitHub issues on some of the more common feature requests, and explain in more detailed context than ROI why some features may not be available.

The DDL section was hard to read, so I reformatted it to focus on what was missing versus what was supported.

The ANALYZE TABLE update fixes #2478

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

fixes #2478 + some additional changes.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added contribution This PR is from a community contributor. size/large Changes of a large size. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jul 6, 2020
@ti-srebot ti-srebot self-assigned this Jul 6, 2020
Comment thread mysql-compatibility.md Outdated
@ghost
Copy link
Copy Markdown

ghost commented Jul 6, 2020

The difference between dev and 4.0, was that 4.0 still had a line about invisible indexes (added in master). Because this is an 8.0 feature anyway, it doesn't need to be documented in mysql-compatibility, which claims only 5.7 compatibility.

Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@lilin90,Thanks for your review.

@ghost ghost merged commit c579b56 into pingcap:release-4.0 Jul 6, 2020
@lilin90 lilin90 deleted the release-4.0-061857f369ec branch July 7, 2020 02:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants